[
http://jira.codehaus.org/browse/MOJO-943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_112330
]
Eirik Bjørsnøs commented on MOJO-943:
-------------------------------------
Hi Oleksandr,
I've taken a quick look at your patch and I have a few questions. It looks like
your trying to achieve a couple of different things:
1) Add a flag to internet-enable the DMG.
This sounds like a cool feature that we'll definitely add.
2) Fixing relative resolving of custom Info.plist template
This was recently fixed in SVN revision 5588. Info.plist references must now
always be absolute, so just use "${basedir}/src/resources" etc.
3) Adding custom webapp resources.
While I'm not sure I fully understand why you would want to do this, I've been
thinking about creating a more general way of specifying project resources to
add to the bundle. Perhaps you could expand a bit on why you need to add webapp
resources and how this is supposed to be used? Wouldn't it be simpler just to
add the war as a dependency and have a separate project for generating the
bundle? Then you can include the war as a dependency and it will be added as a
normal dependency. That's how I do it anyway. I'm not too keen on adding
special behavior checks for war projects.
4) Fixing a problem with using the Velocity component.
I'm not able to reproduce any problem and you didn't really describe what the
problem was. What version of Maven are you using?
5) You'd like the name of the stub file to be the same as the source, and not
have the plugin rename it to "JavaApplicationStub"
Sounds fine to me, we'll add this and make CFBundleExecutable name follow the
name of the actual javaApplicationStub.
6) Processing the javaApplicationStub as a template
Hmm.. It's not clear to me what the purpose of this template is. Is there
something you can't do in the main method?
I'll add 1) and 5) as separate Jira issues.
> Web applications and flexible relsources dependencies support with internet
> enabling.
> -------------------------------------------------------------------------------------
>
> Key: MOJO-943
> URL: http://jira.codehaus.org/browse/MOJO-943
> Project: Mojo
> Issue Type: Improvement
> Components: osxappbundle
> Reporter: Oleksandr Maksymchuk
> Assignee: Eirik Bjørsnøs
> Attachments: osxappbundle-maven-plugin.patch
>
>
> I've used plugin you contributed to mojo and modified it greatly to be
> more flexible to package my web application having different structure
> from simple jar applications.
> Generealy I had issues running it and some confusion with version in
> svn and sources in repo, so I needed to change:
> - * @component
> role="org.codehaus.plexus.velocity.VelocityComponent"
> role-hint="default"
> + * @component role="org.codehaus.plexus.velocity.VelocityComponent"
> * @readonly
> */
> private VelocityComponent velocity;
> + // role-hint="default"
> Don't now how role-hint="default" is in effect but it were erroring
> when running maven with this plugin.
> Also I there were issue (which might be related) that velocity
> component looked at the template and needed relative path from
> _current_ directory, not the project base one.
> Were discovered as I have multiproject pom.
> Also I added:
> + /**
> + * Internet enables dmg files after one is created.
> + *
> + * @parameter expression="${internetEnable}"
> + */
> + private boolean internetEnable;
> - /**
> + /**
> + * Is this webapp project. Default is [EMAIL PROTECTED] true} if
> project
> packaging is 'war' and [EMAIL PROTECTED] false} otherwise.
> + *
> + * @parameter expression="${isWebapp}"
> + */
> + private boolean isWebapp = false;//
> project.getPackaging().equals("war");
> +
> + /**
> + * The location of the produced Zip file containing the bundle.
> + *
> + * @parameter
> expression="${project.build.directory}/${project.build.finalName}"
> + */
> + private File resourcesDirectory;
> +
> + /**
> + * Web application directory to copy resources to. Used when [EMAIL
> PROTECTED]
> isWebapp} set to [EMAIL PROTECTED] true}.
> + * Default 'webapp'.
> + *
> + * @parameter expression="${webappDirectory}"
> + */
> + private String webappDirectory = "webapp";
> +
> + /**
> + * The comma separated list of tokens to include in the bundle.
> + * Default is '**'.
> + *
> + * @parameter expression="${includes}"
> + */
> + private String includes = "**";
> +
> + /**
> + * The comma separated list of tokens to exclude from the bundle.
> + *
> + * @parameter expression="${excludes}"
> + */
> + private String excludes;
> for flexability to create web application.
> And fixed issue with command line that needed to have some wait time
> to execute before proceeding with the next command (so actually dmg
> command worked only on small build projects).
> One minus/todo I needed to use and build file to copy dependencies...
> wich might could be handled by plugin itself, ant were a quick
> solution here to exclude some not needed libraries and resources from
> final war.
> Thanks for your work,
> Oleksandr Maksymchuk,
> OMax
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list please visit:
http://xircles.codehaus.org/manage_email
