[
http://jira.codehaus.org/browse/MTAGLIST-26?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nate Stoddard updated MTAGLIST-26:
----------------------------------
Attachment: MTAGLIST-26.patch
Most of the changes were updates to javadoc comments and renaming function
argument variables that hide scope of class member variables.
I do have concerns about two of the errors:
File: TagListReport.java
Line 142
Text: Variable 'reactorProjects' must be private and have accessor methods.
File: TagListReport.java
Line 149
Text: Variable 'aggregate' must be private and have accessor methods.
These two variables were "protected" scope, so I was able to make them private
for this plugin; however, I am concerned that they were protected for some
other reason. Were these variables protected to allow another plugin to
inherit the TagListReport and have access to these variables without accessor
functions?
In addition, I was not able to resolve the method length error in
FileAnalyser.java.
> Clean up checkstyle results
> ---------------------------
>
> Key: MTAGLIST-26
> URL: http://jira.codehaus.org/browse/MTAGLIST-26
> Project: Maven 2.x Taglist Plugin
> Issue Type: Bug
> Affects Versions: 2.1
> Reporter: Nate Stoddard
> Priority: Trivial
> Attachments: MTAGLIST-26.patch
>
>
> Currently there are 4 errrors, 55 warnings, and 6 infos in the checkstyle
> results. None of these failures appear to be major; however, when changes
> are made to the plugin it is difficult to confirm that no new checkstyles
> failures were created. If there are zero checkstyle failures, as there are
> with PDM and CPD reports, then the addition of any failure would be easily
> detected.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list please visit:
http://xircles.codehaus.org/manage_email
