[
http://jira.codehaus.org/browse/MOJO-1026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_121804
]
lacostej edited comment on MOJO-1026 at 1/30/08 3:05 PM:
---------------------------------------------------------------
I had to disable this for the project to build
{code}
</excludes>
<!--compilerArguments>
<verbose/>
<bootclasspath>${settings.localRepository}/com/sun/rt/1.4.2_13/rt-1.4.2_13.jar</bootclasspath>
</compilerArguments-->
</configuration>
<!--dependencies>
<dependency>
<groupId>com.sun</groupId>
<artifactId>rt</artifactId>
<version>1.4.2_13</version>
</dependency>
</dependencies-->
</plugin>
{code}
The site
* examples/example.html has a typo in the xdoc file name (exemple.xml). By the
way this file could use better formatting.
* might be useful to describe what to do to add support to extra trackers
I looked briefly at the code. Some comments:
* code formatting isn't following project standard (1450 checkstyle errors)
* some comments are in French (e.g. in POM or site.xml)
* your might want to provide a french translation for the report
* some strings are hardcoded in the scm activity report
* in the scm activity report, some fields could be made @required
* hashcode() in SvnTargetEnum treats this.name == null as a potential case
(shouldn't and not consistent with equals). Same for others.
* super() is optional
* in AbstractBufferedConsumer you could change the analize() contract change
and make it return the elements, and get rid off the analyzed field and test
for elements == null instead. Makes analyze() self contract descriptive
* you can reuse server in loadInfosFromSettings()
and as Trygvis said in the mailing list, how hard to make this scm independant ?
as for the bug Tracker interface, it would be nice to start a project to handle
common issue trackers operations. But that's for later on...
Hope that helps.
was (Author: lacostej):
I had to disable this for the project to build
</excludes>
<!--compilerArguments>
<verbose/>
<bootclasspath>${settings.localRepository}/com/sun/rt/1.4.2_13/rt-1.4.2_13.jar</bootclasspath>
</compilerArguments-->
</configuration>
<!--dependencies>
<dependency>
<groupId>com.sun</groupId>
<artifactId>rt</artifactId>
<version>1.4.2_13</version>
</dependency>
</dependencies-->
</plugin>
The site
* examples/example.html has a typo in the xdoc file name (exemple.xml). By the
way this file could use better formatting.
* might be useful to describe what to do to add support to extra trackers
I looked briefly at the code. Some comments:
* code formatting isn't following project standard (1450 checkstyle errors)
* some comments are in French (e.g. in POM or site.xml)
* your might want to provide a french translation for the report
* some strings are hardcoded in the scm activity report
* in the scm activity report, some fields could be made @required
* hashcode() in SvnTargetEnum treats this.name == null as a potential case
(shouldn't and not consistent with equals). Same for others.
* super() is optional
* in AbstractBufferedConsumer you could change the analize() contract change
and make it return the elements, and get rid off the analyzed field and test
for elements == null instead. Makes analyze() self contract descriptive
* you can reuse server in loadInfosFromSettings()
and as Trygvis said in the mailing list, how hard to make this scm independant ?
as for the bug Tracker interface, it would be nice to start a project to handle
common issue trackers operations. But that's for later on...
Hope that helps.
> Svnchangelog-maven-plugin
> -------------------------
>
> Key: MOJO-1026
> URL: http://jira.codehaus.org/browse/MOJO-1026
> Project: Mojo
> Issue Type: New Feature
> Environment: Maven 2.0.8
> Reporter: Emmanuel Hugonnet
> Attachments: svnchangelog-maven-plugin.tar.gz
>
>
> New mojo that produces a report equivalent to the maven-changes-plugin but
> using subversion commit logs instead of an XML file.
> This was first submitted as a enhancement for the maven-changes-plugin but it
> doesn't seem to fit in their view :o(
> (http://jira.codehaus.org/browse/MCHANGES-78);
> With more than 14 votes and some interests on the mojo-dev mailing list, I
> therefore sumit it
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list please visit:
http://xircles.codehaus.org/manage_email
