[ 
http://jira.codehaus.org/browse/MJAVACC-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_121904
 ] 

Paul Gier commented on MJAVACC-57:
----------------------------------

{quote} To my knowledge, Maven itself does not care whether we call the next 
version 2.3.1, 2.4 or 3.0 {quote}

Yes, you're right maven will not distinguish the version, and will download the 
latest for those builds that do not explicitly set a version.  In my opinion 
Maven should have been set up to require plugin versions (and let people who 
really want RELEASE or LATEST specify that), but that's a different issue.
If we do include a flag to skip the javacc execution and default it to not run 
javacc, I believe backwards compatibility could be maintained with very little 
added complexity, but I could be wrong.

{quote} In general, I do not believe in merging different use-cases into the 
same mojo.  First, it makes this mojo more complex and increases the likelyhood 
that developers make errors during code maintainance.{quote}

I think you'll always have some degree of multiple use cases in a mojo, but I 
know what you mean in this case.  Since we don't have any good examples of 
jjtree by itself as an actual use case, it seems to me to reduce the total 
complexity of the plugin (fewer mojos, less duplication) if you modify the 
current jjtree and jtb instead of introducing new mojos.

Overall, I think either approach is fine though.  I just wanted to bring up 
this other approach for a little discussion :)


> Allow jjtree to automatically execute javacc
> --------------------------------------------
>
>                 Key: MJAVACC-57
>                 URL: http://jira.codehaus.org/browse/MJAVACC-57
>             Project: Maven 2.x JavaCC Plugin
>          Issue Type: New Feature
>          Components: jjtree
>            Reporter: Paul Gier
>            Assignee: Benjamin Bentmann
>             Fix For: 2.x
>
>
> The common use case for jjtree is to first run the jjtree-mojo and then run 
> the javacc-mojo on the output of jjtree.  This requires the configuration of 
> two mojo executions.  It would be nice if the jjtree mojo automatically 
> called javacc on it's output by default.  This way only one execution would 
> be needed.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe from this list please visit:

    http://xircles.codehaus.org/manage_email

Reply via email to