[
http://jira.codehaus.org/browse/MJAVACC-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_122230
]
bentmann edited comment on MJAVACC-73 at 2/3/08 5:35 PM:
------------------------------------------------------------------
Committed in r6204.
I chose to introduce a little break with backward-compatibility by defaulting
the mojo parameters "nodePackageName" to "\*.syntaxtree" and
"visitorPackageName" to "\*.visitor". Rationale: The original default values
("syntaxtree" and "visitor") are rather inappropriate for real-word use-cases
where people store their files in well structured package hierarchies. Hence, I
do not expect anybody really using the jtb mojo with its default values. On the
other hand, the new default values deliver senseful output packages such that
new users now can take advantage of an easy plugin configuration, especially in
the case of multiple \*.jtb input files.
was (Author: bentmann):
Committed in r6204.
I chose to introduce a little break with backward-compatibility by defaulting
the mojo parameters "nodePackageName" to "*.syntaxtree" and
"visitorPackageName" to "*.visitor". Rationale: The original default values
("syntaxtree" and "visitor") are rather inappropriate for real-word use-cases
where people store their files in well structured package hierarchies. Hence, I
do not expect anybody really using the jtb mojo with its default values. On the
other hand, the new default values deliver senseful output packages such that
new users now can take advantage of an easy plugin configuration, especially in
the case of multiple *.jtb input files.
> Make JTB mojo use package of input grammar by default
> -----------------------------------------------------
>
> Key: MJAVACC-73
> URL: http://jira.codehaus.org/browse/MJAVACC-73
> Project: Maven 2.x JavaCC Plugin
> Issue Type: Improvement
> Components: jtb
> Affects Versions: 2.3
> Reporter: Benjamin Bentmann
> Assignee: Benjamin Bentmann
> Fix For: 2.4
>
>
> Right now, the jtb mojo always requires the user to explicitly set the
> package name for visitor/syntaxtree files if these files should end up in a
> real world package. The mojo should default its parameter "packageName" to
> the package from the input file to free the user from this error-prone
> setting in the plugin config. Besides, this will allow to process multiple
> grammar files using a single mojo execution rather than n individual
> executions (less config, faster build).
> Also interesting would be the possibility to simply alter the sub package for
> visitor/syntaxtree files, e.g. use "\*.ast" instead of "*.syntaxtree". The
> required mojo configuration might look like
> {code:xml}
> <nodePackageName>*.ast</nodePackageName>
> {code}
> where the (invalid identifier character) asterisk is used as a marker for the
> mojo to replace the leading package part with the package name of the grammar
> file.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list please visit:
http://xircles.codehaus.org/manage_email
