[ 
http://jira.codehaus.org/browse/MFITNESSE-19?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Bentmann closed MFITNESSE-19.
--------------------------------------

         Assignee: Benjamin Bentmann  (was: pkernevez)
       Resolution: Fixed
    Fix Version/s: 1.0-beta-3

Applied in r6336, thanks!

One final note: Luca, please follow the [Maven Code 
Style|http://maven.apache.org/developers/committer-environment.html#maven_code_style]
 when submitting patches. This reduces meaningless diffs. Furthermore, please 
have your SVN client use relative paths in the diff files (e.g. src/main/... 
instead of /home/luca/...). Otherwise, your patches can only be applied after 
manual correction.

> os agnistic path test assertion
> -------------------------------
>
>                 Key: MFITNESSE-19
>                 URL: http://jira.codehaus.org/browse/MFITNESSE-19
>             Project: Maven 2.x Fitnesse Plugin
>          Issue Type: Test
>    Affects Versions: 1.0-beta-3
>         Environment: GNU/Linux
>            Reporter: Luca Marrocco
>            Assignee: Benjamin Bentmann
>            Priority: Trivial
>             Fix For: 1.0-beta-3
>
>         Attachments: osAgnosticPathTest.patch
>
>
> on GNU/Linux separatorChar is /. The assertion in test fail because it is 
> expressed using non GNU/Linux separatorChar
> i have fixed this problem, as summarized below:
> * FitnessePageTest fix replaceing // with \
> * FitnesseReportMojoTest adding function osAgnosticPath that replace \\ and / 
> with File.separatorChar and viceversa, using it into assertion fix the error
> * FitnesseRunnerMojoTest.testPrepareCommandLine replace "bidon.jar;" with 
> "bidon.jar" + File.separatorChar

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


Reply via email to