commas in dname should be escaped when generating keys
------------------------------------------------------

                 Key: MWEBSTART-112
                 URL: http://jira.codehaus.org/browse/MWEBSTART-112
             Project: Maven 2.x Webstart Plugin
          Issue Type: Bug
          Components: sign
    Affects Versions: 1.0-alpha-2
            Reporter: Brad Fritz
            Priority: Minor
         Attachments: escape_commas_in_dname.patch

JarSignMojoConfig should probably escape unescaped commas in dname
components so the keytool call does not fail when generating new keys.

The attached patch adds escaping and a test.  A more complete solution
would only escape the comma if it is not already escaped.

The user could manually escape the dname components when specifying
the "sign" element, but having the plugin escape them is convenient
for cases like this:

  <sign>
    [..]
    <dnameO>${project.Organization.Name}</dnameO>
  
    <keystoreConfig>
      <delete>false</delete>
      <gen>true</gen>
    </keystoreConfig>
  </sign>

where the organization name contains a comma, e.g. "My Co, Inc." or
"Foo, LLC".



-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


Reply via email to