[ 
http://jira.codehaus.org/browse/MWEBSTART-113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_126030
 ] 

Andreas Kuhtz commented on MWEBSTART-113:
-----------------------------------------

Hi Kevin,

Yes, you're right, It's definitely a better solution to put this into 
{{JarResource}}.
For the {{Generator}} class you could temporarily create a {{JarResource}} that 
wraps the current {{Artifact}} and use the same mechanism as in {{JarResource}}.

Something like this:
{code} 
[...]
for (int i = 0; i < artifacts.size(); i++) {
    Artifact artifact = (Artifact)artifacts.get(i);
    JarResource jarResource = new JarResource(artifact);
    buffer.append(jarResource.getJnlpText();
    buffer.append("\n");
[...]

{code} 

> SNAPSHOT-artifacts should be downloaded always
> ----------------------------------------------
>
>                 Key: MWEBSTART-113
>                 URL: http://jira.codehaus.org/browse/MWEBSTART-113
>             Project: Maven 2.x Webstart Plugin
>          Issue Type: Improvement
>          Components: jnlp-download-servlet
>    Affects Versions: 1.0-alpha-2
>            Reporter: Andreas Kuhtz
>         Attachments: pom.xml.diff
>
>
> I'm using version-download protocol. This works fine, however I found a 
> problem:
> If a SNAPSHOT-artifact is already downloaded you must always clean the cache 
> to have it downloaded again if the content was changed (--> new timestamp). 
> This is currently not the case but a small change can be applied that works. 
> I've attached a patch.
> If a SNAPSHOT-artifact is detected the jar-entry (<jar href="...) is 
> different than in normal case. See the output below. 
> {noformat}
> [...]
>   <resources>
>     <j2se version="1.6+"/>
>     <jar href="sample-client-appl-1.0-SNAPSHOT.jar" main="true"/>
>     <jar href="sample-domain-1.0-SNAPSHOT.jar"/>
>     <jar href="spring-aspects.jar" version="2.5.1"/>
> [...]
> {noformat} 
> The spring-aspects.jar is downloaded only once (independent of the timestamp 
> of the file). The 2 SNAPSHOT artifacts are downloaded if the timestamp of the 
> file is newer than the one in the cache.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


Reply via email to