Damn, I don't know how I missed that the version should be 2.0-beta-1. I
updated the jira project to show the correct versions now.
I have fixed most of the checkstyle errors, except for two warnings which I will
leave for a future release. I left the ITs off by default just for convenience
to not wait for them to run. I changed them to be on by default now, and took
your suggestions about using jdk14 activation and pom excludes.
Thanks for the help!
Benjamin Bentmann wrote:
I'd like to release the jboss-packaging-maven-plugin version 1.0-beta-1.
Sure about the version, the POM is currently at 2.0-SNAPSHOT... ?
Nothing serious: There are some Checkstyle warning/errors. Maybe fix
right before release or postpone?
As for the ITs: The activation
<activation>
<jdk>1.5</jdk>
</activation>
will jump in for Java 1.5 *only*, it will not be activated for Java 1.6
or newer. You can consider to use the syntax <jdk>1.5+</jdk> which
requires Maven 2.0.7 (MNG-1910) or you do it the other way round:
Instead of including ITs for Java 1.5+, exclude ITs for Java 1.4-. Since
we have 1.4 as the minimum requirement, this condition can be simplified
to <jdk>1.4</jdk>, hence this condition also works with any Maven 2.0.x.
That's how I handled the JTB ITs over at the JavaCC plugin.
Last but not least, when you spend time to setup nice ITs, why not have
them run by default just like ordinary unit tests to show everybody how
well behaving the plugin is?
Benjamin
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
