[
http://jira.codehaus.org/browse/MJNCSS-31?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=136908#action_136908
]
bentmann edited comment on MJNCSS-31 at 5/31/08 3:51 PM:
------------------------------------------------------------------
bq. This will make the forceEncoding option redundant, or I miss something ?
If the employed {{SAXReader}} is really not capable of detecting the file
encoding from the XML declaration, the plugin should simply use
{{WriterFactory.newXmlReader()}} from plexus-utils and pass the reader to
[{{SAXReader.read(Reader)}}|http://www.dom4j.org/apidocs/org/dom4j/io/SAXReader.html#read(java.io.Reader)].
I agree with Hervé, the parameter {{forceEncoding}} should be removed. Deleting
mojo parameters shouldn't cause any harm with backward-compat, IIRC Maven
silently ignore configuration elements from the POM for which no corresponding
setter/field exists on the mojo.
was (Author: bentmann):
bq. This will make the forceEncoding option redundant, or I miss something ?
If the employed {{SAXReader}} is really not capable of detecting the file
encoding from the XML declaration, the plugin should simply use
{{WriterFactory.newXmlReader()}} from plexus-utils and pass the reader to
[{{SAXReader.read(Reader)}}|http://www.dom4j.org/apidocs/org/dom4j/io/SAXReader.html#read(java.io.Reader)].
> add an "encoding" parameter for source files and use
> ${project.build.sourceEncoding} as default value
> -----------------------------------------------------------------------------------------------------
>
> Key: MJNCSS-31
> URL: http://jira.codehaus.org/browse/MJNCSS-31
> Project: Maven 2.x JavaNCSS Plugin
> Issue Type: New Feature
> Reporter: Herve Boutemy
> Assignee: Jean-Laurent de Morlhon
>
> see
> http://docs.codehaus.org/display/MAVENUSER/POM+Element+for+Source+File+Encoding
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
