[
http://jira.codehaus.org/browse/CBUILDS-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=149920#action_149920
]
stimpy edited comment on CBUILDS-27 at 10/4/08 3:14 PM:
--------------------------------------------------------------
Might need some help on this one. The backout is easy enough, but it breaks my
build of "git".
This code exists in the GIT Makefile
ifdef NO_R_TO_GCC_LINKER
CC_LD_DYNPATH = -Wl,-rpath=
else
CC_LD_DYNPATH = -R
endif
When I compile GIT with gcc 3.x on a RHAS3 linux box, I have to set this
environment variable to anything.
NO_R_TO_GCC_LINKER
When I compile on a Mac I shouldn't set it to anything. So right now, I set
this build profile.
<profiles>
<profile>
<id>git-non-linux-build</id>
<activation>
<activeByDefault>true</activeByDefault>
</activation>
<properties>
<gitCompileEnvvar>SomethingThatWillBeIgnored</gitCompileEnvvar>
</properties>
</profile>
<profile>
<id>git-linux-build</id>
<activation>
<os>
<name>unix</name>
<family>linux</family>
</os>
</activation>
<properties>
<gitCompileEnvvar>NO_R_TO_GCC_LINKER</gitCompileEnvvar>
</properties>
</profile>
</profiles>
Which sets this property and things go okay
<compileEnvironment>
<property>
<name>${gitCompileEnvvar}</name>
<value>yes</value>
</property>
</compileEnvironment>
When you switch it to a Map instead of a Property, maven barfs when reading the
pom as the XML tag can't be expanded
<code>
<compileEnvironment>
<${gitCompileEnvvar}>yes</${gitCompileEnvvar}>
</compileEnvironment>
</code>
So the more verbose configuration syntax is better here as it gives me control
of name and value unless there is another XML pom trick I can do to get the
conditional environment variable setup properly.
BTW - found docs on how to confix a MAP in you pom here
http://maven.apache.org/guides/plugin/guide-java-plugin-development.html
was (Author: stimpy):
Might need some help on this one. The backout is easy enough, but it
breaks my build of "git".
This code exists in the GIT Makefile
ifdef NO_R_TO_GCC_LINKER
CC_LD_DYNPATH = -Wl,-rpath=
else
CC_LD_DYNPATH = -R
endif
When I compile GIT with gcc 3.x on a RHAS3 linux box, I have to set this
environment variable to anything.
NO_R_TO_GCC_LINKER
When I compile on a Mac I shouldn't set it to anything. So right now, I set
this build profile.
<profiles>
<profile>
<id>git-non-linux-build</id>
<activation>
<activeByDefault>true</activeByDefault>
</activation>
<properties>
<gitCompileEnvvar>SomethingThatWillBeIgnored</gitCompileEnvvar>
</properties>
</profile>
<profile>
<id>git-linux-build</id>
<activation>
<os>
<name>unix</name>
<family>linux</family>
</os>
</activation>
<properties>
<gitCompileEnvvar>NO_R_TO_GCC_LINKER</gitCompileEnvvar>
</properties>
</profile>
</profiles>
Which sets this property and things go okay
<compileEnvironment>
<property>
<name>${gitCompileEnvvar}</name>
<value>yes</value>
</property>
</compileEnvironment>
When you switch it to a Map instead of a Property, maven barfs when reading the
pom as the XML tag can't be expanded
<compileEnvironment>
<${gitCompileEnvvar}>yes</${gitCompileEnvvar}>
</compileEnvironment>
So the more verbose configuration syntax is better here as it gives me control
of name and value unless there is another XML pom trick I can do to get the
conditional environment variable setup properly.
BTW - found docs on how to confix a MAP in you pom here
http://maven.apache.org/guides/plugin/guide-java-plugin-development.html
> Use Map instead of Properties for plugin configurations
> -------------------------------------------------------
>
> Key: CBUILDS-27
> URL: http://jira.codehaus.org/browse/CBUILDS-27
> Project: Mojo C Builds
> Issue Type: Bug
> Affects Versions: 1.0-alpha-5
> Reporter: Dan Tran
> Assignee: Dan Tran
> Fix For: 1.0-alpha-5
>
>
> It is best not to use java Properties, but use Map instead which has
> a much shorter configuration and accept project.* interpolation.
> Surefire plugin is switching to this interface.
> see http://jira.codehaus.org/browse/SUREFIRE-511 for details
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
