>I am not sure what exactly your settings should do but from the path of >your special test settings I assumed these were meant to provide some >special test setup, different from your usual Maven settings. My >suggestion aimed at sharing these test settings will other developers >for reproducibility.
Hi Benjamin, I just start to use the Verifier approach for automating our integration test. On my PC I don't use the default location of the maven settings.xml. When using maven with shell, maven use my system properties which contains this property: MAVEN_OPTS=-Duser.home=c:\dev\apps\maven The Verifier mechanism doesn't seem to use the system property. So I just test if I found my own settings.xml, if not then use the defaut location. With this code, this test will pass on all other developers that will use the default location. I may test the system properties for looking for a MAVEN_OPTS property and parse it... What do you think about that ? Philippe -----Original Message----- From: Benjamin Bentmann [mailto:[email protected]] Sent: mercredi 21 janvier 2009 18:08 To: [email protected] Subject: Re: [mojo-dev] Re: [mojo-scm] [8700] trunk/mojo/fitnesse-maven-plugin/src/test/resources: Run all the integration test at each build. Hi Philippe, > This is a test class, so what difference do you see between a constant and e > file located just around this class ? I am not sure what exactly your settings should do but from the path of your special test settings I assumed these were meant to provide some special test setup, different from your usual Maven settings. My suggestion aimed at sharing these test settings will other developers for reproducibility. > If I use a system property I need to configure it my test config of > Eclipse... That's right of course. > With this code I support my configuration and a default configuration. My concern was basically how the current approach would scale to multiple developers, i.e. if each and every developer would need to hard-code his/her settings path in the source. > What do you think ? You're the plugin maintainer, if none of my suggestions works, just keep going as is :-) Benjamin --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
