[ 
http://jira.codehaus.org/browse/MSQL-34?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=163717#action_163717
 ] 

John Newman commented on MSQL-34:
---------------------------------

No, the current skip param can be placed inside the global config AND/OR inside 
of one of the individual executions.  I think this is surprising you, but yes 
this is how the plugin works as of today.  So there already is a runnable 
profile inside this plugin, I'm not sure if you are aware of it.   However if 
you do this, it works until you try use the global skip property - individual 
executions that specify a skip are run anyway.

So to be clear, I am not asking to create a globalSkip since we already have 
it.  I am asking to change the overriding scope of the existing skip property, 
which can already be declared at both levels.

If a simple test case would help you see what I'm attempting to explain, let me 
know and I will produce one.

"sometimes 40line of duplicated code is the way to go"  certainly not.  I am 
not interested in copying 4 different <execution> blocks into 4 different 
profiles, duplication is never the way to go IMO.  The plugin is close to 
working correctly, it just needs a small tweak - if global skip is specified, 
don't run anything.

> More control over skip property - global configuration vs individual 
> executions
> -------------------------------------------------------------------------------
>
>                 Key: MSQL-34
>                 URL: http://jira.codehaus.org/browse/MSQL-34
>             Project: Maven 2.x SQL Plugin
>          Issue Type: Wish
>            Reporter: John Newman
>
> Hello,
> I'm having issues with the scope of the skip property.  
> If I pass maven test skip, i don't want anything at all to run.  So I have
> <configuration>
>       <skip>${maven.test.skip}</skip>
> But i have a bunch of different executions, I need some of them to not run 
> for certain environments.
> <execution><id>test-data</id><skip>${skipTestData}</skip>
> However if I simply run mvn -Dmaven.test.skip=true , the test data tries to 
> run anyway (skip is overridden).  To me, this is a bug.  To others, it might 
> be a feature.
> Really what is needed is a property <globalSkipOverridesIndividual> which is 
> false by default.  As of now I have to do -Dmaven.test.skip=true 
> -DskipTestData=true, which is fine, but I have 8 or so skip lines to pass 
> in...
> Thanks.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


Reply via email to