[ 
http://jira.codehaus.org/browse/MOJO-1303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=171899#action_171899
 ] 

Krashan Brahmanjara edited comment on MOJO-1303 at 4/3/09 5:51 AM:
-------------------------------------------------------------------

BTW 
On Maven 2.1.0 it works. But some users may got problems with configuration 
definition.

For command mvn properties:read-project-properties, properties xml should be 
defined
as
  <plugin> 
         (...)
        <executions>
          <execution>
            <phase>validate</phase>
            <goals>
              <goal>read-project-properties</goal>
            </goals>
          </execution>
        </executions>
        <configuration>
          <files>
            <file>revision.xml</file>
           </files>
        </configuration>
      </plugin>

I suggest correct configuration identification and change some log.debug to 
log.info because users don't that error occurs and properties are readed


      was (Author: krokodylowy):
    BTW 
On Maven 2.1.0 it works but configuration cannot be defined in execution 
section only like in example


  <plugin>
        <groupId>org.codehaus.mojo</groupId>
        <artifactId>properties-maven-plugin</artifactId>
        <version>1.0-alpha-3-SNAPSHOT</version>
        <executions>
          <execution>
            <phase>validate</phase>
            <goals>
              <goal>read-project-properties</goal>
            </goals>
          </execution>
        </executions>
        <configuration>
          <files>
            <file>revision.xml</file>
           </files>
        </configuration>
      </plugin>

I suggest correct configuration identification and change some log.debug to 
log.info because users don't that error occurs and properties are readed

  
> read-project-properties in parent pom does not make the properties accessible 
> for child modules
> -----------------------------------------------------------------------------------------------
>
>                 Key: MOJO-1303
>                 URL: http://jira.codehaus.org/browse/MOJO-1303
>             Project: Mojo
>          Issue Type: Bug
>          Components: properties
>            Reporter: Dirk Olmes
>            Priority: Critical
>         Attachments: projects-with-plugin.zip, projects-with-property.zip, 
> ReadPropertiesMojo.java, ReadPropertiesMojo.patch
>
>
> Declaring a property in a parent pom (reactor build) makes it available for 
> all child modules. Reading in properties using the read-project-properties 
> goal fails to make the properties read from the file available in child 
> modules.
> I have attached two sets of poms demonstrating the bug: if you build the 
> contents of projects-with-property.zip the final name of the baz1 jar will 
> include the value of the declared property. If you build the contents of 
> projects-with-plugin.zip the final name of the bar1 jar will not include the 
> value of the read property.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


Reply via email to