[
http://jira.codehaus.org/browse/MTOMCAT-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=172496#action_172496
]
Simone Gianni commented on MTOMCAT-23:
--------------------------------------
Moreover the code looks for packaging.equals("war"), this makes it impossible
to make it work with alternative packagings that still produce a war. If I
understand it correctly, I think it should check for type.equals("war"), which
anyway works with the default packaging, as described here
http://docs.codehaus.org/display/MAVEN/Packaging+vs+Type+-+Derived+and+Attached+Artifacts
.
> Allow to deploy assembled wars
> ------------------------------
>
> Key: MTOMCAT-23
> URL: http://jira.codehaus.org/browse/MTOMCAT-23
> Project: Maven 2.x Tomcat Plugin
> Issue Type: Improvement
> Affects Versions: 1.0-beta-1
> Reporter: Ulrich David
>
> We are assembling our wars with the assembly plugin in a project that has pom
> packaging so we can not use the tomcat plugin to deploy our wars.
> Pls. allow to configure overwriting the isWar() functionality checking the
> packaging:
> E.G. change AbstractRunMojo.java with (i am not familiar with the patch
> format so here inline:)
> {code:java}
> /**
> * If set to true ignore if packaging of project is not 'war'.
> *
> * @parameter expression="false"
> */
> private boolean ignorePackaging;
> 221 /**
> 222 * Gets whether this project uses WAR packaging or if it shoud be
> ignored.
> 223 *
> 224 * @return whether this project uses WAR packaging or if it should be
> ignored.
> 225 */
> 226 protected boolean isWar()
> 227 {
> 228 return "war".equals( packaging ) || ignorePackaging;
> 229 }
> {code}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
