Tested and it works fine.How will it handle the future versions of the server ? We won't have to update it for each server version like it is for now ? +0 due to benjamin's remarks. I prefer that you fix them first.
Arnaud On Fri, Apr 17, 2009 at 8:00 PM, Benjamin Bentmann < [email protected]> wrote: > Simon Brandhof wrote: > > I'd like to make the first beta-release of the Sonar Mojo. >> > > +0, not using it. Notes: > > "mvn docck:check" reports a missing <description> element for the plugin > project. > > The <organization> element in the POM is inherited from the mojo-parent so > can be removed. > > For the SCM URL, using the link to FishEye ( > http://fisheye.codehaus.org/browse/mojo/trunk/mojo/sonar-maven-plugin) > would provide a richer interface for browsing. > > "mvn dependency:analyze" reports several undeclared dependencies. > > The parameters "project" and "session" in SonarMojo are not really meant > for user configuration so should better be marked as @readonly to exclude > them from the goal documentation. > > In this context, the recommended way to inject POM values is > @parameter default-value="${...}" > instead of expression="". While there's in most cases no technical > difference regarding the end result, expression is conceptually meant for > injection of system/CLI properties. > > For future inter-op with other Mojo developers, consider to adopt the Maven > code style and SVN config used for Mojo [0]. > > On this occasion, welcome on board! > > > Benjamin > > > [0] http://mojo.codehaus.org/development/guidelines.html > > --------------------------------------------------------------------- > To unsubscribe from this list, please visit: > > http://xircles.codehaus.org/manage_email > > > -- Arnaud
