[
http://jira.codehaus.org/browse/MGWT-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=174418#action_174418
]
Stefan Hübner commented on MGWT-55:
-----------------------------------
Back in office now. Thank you for applying the patch!
I'm checking the original implementation of
{{CompilerMojo#compilationRequired(String, File)}} to reevluate my point. My
motivation to change its behaviour was to fix a problem (which I'm rechecking
right now to be sure I didn't oversee something), not only to improve
productivity. I'll get back to that, when I can provide a better description of
that particular issue.
Regarding the IT-tests and documentation: I'll check that test and I would also
be happy to contribute a documentation page for "multi-project" setups (but the
latter one might take some days).
Regarding your question about dependency change detection in general: Focussing
on SNAPSHOT-dependecies might make the task a bit easier, but I'm not sure
here. I've seen such a feature in CruiseControl. They have a
"Maven2SnapshotDependencies" modificationset-Plugin, which fingers
timestamp-information about SNAPSHOT-dependencies from the local maven repo.
Maybe that could serve as a starting point.
> Consider (re)sourcesOnPath when checking for required compilation
> -----------------------------------------------------------------
>
> Key: MGWT-55
> URL: http://jira.codehaus.org/browse/MGWT-55
> Project: Maven 2.x GWT Plugin
> Issue Type: Improvement
> Affects Versions: 1.1
> Reporter: Stefan Hübner
> Assignee: nicolas de loof
> Priority: Minor
> Fix For: 1.1
>
> Attachments: MGWT.patch
>
>
> In our multi-module project CompileMojo doesn't notice changed sources, if
> those sources reside in a module which is a sibbling to the WAR module. So
> the application won't get recompiled. This is because
> {{CompileMojo#compilationRequired()}} doesn't respect {{sourcesOnPath}} and
> {{resourcesOnPath}}.
> Attached is patch to fix this behaviour. It has been tested on our projects.
> Cheers!
> Stefan
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
