[
http://jira.codehaus.org/browse/MGWT-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=177768#action_177768
]
nicolas de loof commented on MGWT-76:
-------------------------------------
including -source jar in the classpaht is NOT a valid use case : see maven core
ArtifactHandler for java-sources type :
{noformat}
<component>
<role>org.apache.maven.artifact.handler.ArtifactHandler</role>
<role-hint>java-source</role-hint>
<implementation>org.apache.maven.artifact.handler.DefaultArtifactHandler</implementation>
<configuration>
<classifier>sources</classifier>
<type>java-source</type>
<extension>jar</extension>
<language>java</language>
<addedToClasspath>false</addedToClasspath>
</configuration>
</component>
{noformat}
-sources jar as desinged to help debugging, not to create GWT compliant library
with no effort.
Hosted mode will detect all source changed from it's classpath. A GWT
dependency will have the .java source changed because the IDE will copy the
modified resource in target/classes when edited (incremental build, is not a
full maven build). You should definitly test m2eclipse and also the Google
Eclipse plugin.
I don't reject your patch because of phylosophical consideration. I'm also
working with GWT on a huge project with many modules and don't need such hack
to be productive. You should review your modules to ensure they are valid GWT
modules to get used form your web application : declare java source as
resources and include a gwt.xml module with required inherits set.
We can't know anyway the source list of a project without running a
generate-source phase on it. This is definitly a blocker to the "include projet
source folder" strategy.
MGWT-82 is open to ensure we get a good integration with m2eclipse and support
direct reference to projects open in the workspace.
> Solution for multi module builds and hosted mode
> ------------------------------------------------
>
> Key: MGWT-76
> URL: http://jira.codehaus.org/browse/MGWT-76
> Project: Maven 2.x GWT Plugin
> Issue Type: Improvement
> Affects Versions: 1.1, 2.0
> Reporter: Stefan Raubal
> Assignee: nicolas de loof
> Fix For: 2.0
>
> Attachments: dir_structure.txt, gwt-maven-plugin-MGWT-76.rev9744.patch
>
>
> The suggested improvement would ease rapid application development for multi
> module environments:
> The sources of referenced modules should be added to the hosted mode
> classpath instead of the JAR dependency (if the projects are referenced in a
> reactor build).
> The totsp plugin was preparing a solution for multi module builds that share
> the source folders directly. This sounded very promising and was discussed
> here:
> http://code.google.com/p/gwt-maven/issues/detail?id=149
> Nicolas stated correctly in a discussion that the manual configuration step
> used in the totsp patch has drawbacks and proposed a different solution:
> <quote>
> The use of some external XML file to setup "artifact" path as a project path
> is not very maven-compliant, as Maven likes all the config to be in POM. Such
> a feature could be nice but should be supported at maven-core level, not just
> inside a plugin.
> An better option COULD be to reuse code from maven-eclipse-plugin that scans
> the workspace for other maven project and automagically replaces artifacts
> reference with project references. This is a stronger approach : user don't
> have to configure it's path in some XML (that is user dependent, so it SHOULD
> not be stored in SVN and refered from POM) and the plugin code will check the
> candidate project matches the expected version to avoid missconfiguration.
> </quote>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
