[ 
http://jira.codehaus.org/browse/MOJO-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=186530#action_186530
 ] 

Peter Antman commented on MOJO-1357:
------------------------------------

I am sorry you think the patch is a little to big and rough. I, however, did 
not have a set of features and wanted to introduce and JUnit test. Instead, I 
had the hypothesis that the plugin should work with docbook in a multi module 
project. It did not, and the set of patches is everything I had to do to get 
that scenario to work (and It does, we uses the patched version to build or 
releases nowadays).

Apart from that I agree with all your comments. I am sorry about the sloppy 
code comment that slipped through. My goal was to be able to specify xsl-files 
as a catalog resolvable resources. That would have been really nice, since 
xsl:s could then be loaded through dependencies. What the comment means is that 
an xsl specified in the pom.xml as <stylesheet></stylesheet> is not treated as 
a full systemid but is translated to an absolute path. This means it is not 
possible to resolve through the classpath resover or a catalog based resolver.

> Some patches to enhance the resolver and make multi output from xsl work
> ------------------------------------------------------------------------
>
>                 Key: MOJO-1357
>                 URL: http://jira.codehaus.org/browse/MOJO-1357
>             Project: Mojo
>          Issue Type: Wish
>          Components: xml
>    Affects Versions: buildnumber-maven-plugin-1.0-beta-3
>            Reporter: Peter Antman
>            Assignee: Jochen Wiedmann
>            Priority: Minor
>         Attachments: IncludeProjectDependenciesComponentConfigurator.java, 
> pra.diff
>
>
> I have made some improvements the get the plugin to work nicely with docbook 
> xsl. This includes among other things:
>  * Make sure resolver is set on all constructed/resolved Sources
>  * Make multiple output from one xsl land in the correct output directory
>  * Make transformer fail when an error happens in transform
>  * Make it possible to use in multi module setup with different dependencies 
> (use project dependencies)
>  * Enhanced logging in the Resolver
>  * Switched to 1.5 (easy to make 1.4 compatible again)
> Hope it might be useful in some way.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


Reply via email to