[
http://jira.codehaus.org/browse/MTAGLIST-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=190550#action_190550
]
Christoph Pickl commented on MTAGLIST-46:
-----------------------------------------
hi nate,
first of all thanks for the input, and also thanks for your appreciation about
the "file name check logic encapsulation" ;)
regarding user-defined comment strings: of course the whole thing would get
highly configurable (and therefore usable for more people) with the
introduction of such thing. but maybe some investigation has to be done first
(as you seemed not so sure about your own proposition) by creating a list of
comment styles among the different languages to get a picture of the needs.
finally got time to implement the languageExtensions-feature (as to called from
now on):
[patch-taglist-languageExtensions_configuration-cpickl_2009_09_10.txt]
some issues i would need some feedback:
1. artifact handler's language: it is compared with "java" if aggregate is
enabled; could this be a problem for the languageExtensions feature? (see FIXME
tasktag in TagListReport:577)
2. no encoding set: if you dont set the (source-)encoding in your pom, the xml
report fails with a warning; see current version of TagListReport:422. in my
patch i added a null check (as done already in other methods). or use the
"file.encoding" system-property instead?!
3. hm... where to instantiate sourceFileFilter? because it is accessed either
for "taglist:taglist" or "site" in a different method, and there is no
constructor... currently i just access it via a getter with lazy instantiating.
4. i also added some tests, yesss :) by the way refactored the class a bit (new
POM_BASE_PATH constant in TaglistMojoBasicConfigTest)
~christoph
> Support for other programming languages as well
> -----------------------------------------------
>
> Key: MTAGLIST-46
> URL: http://jira.codehaus.org/browse/MTAGLIST-46
> Project: Maven 2.x Taglist Plugin
> Issue Type: New Feature
> Environment: environment independent
> Reporter: Christoph Pickl
> Priority: Minor
> Attachments: patch-taglist-cpickl_2009_09_02.txt
>
>
> currently only java files are supported. but as the syntax of many other
> languages are similar to java's, it should not be that hard to adjust the
> plugin for these other languages.
> changes which have to be made:
> 1) TagListReport#hasSources() ... change ".java"
> 2) FileAnalyser#findFilesToScan() ... change "**/*.java"
> in the attached eclipse patch you will find these changes, plus a
> SourceFileFilter class which handles proper filtering depending on a new
> maven configuration "languageMode" (which can now be either "java" which is
> the default, or "flex" which looks for *.as and *.mxml files).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
