[
http://jira.codehaus.org/browse/MGWT-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=190582#action_190582
]
nicolas de loof commented on MGWT-115:
--------------------------------------
Your patch changes the initialisation principle to preemptively setup the RPC
proxy before any call to getInstance.
Not sure this is a best practice : this may slow down the webUI initialization
time with unecessary setup code execution
also, your patch makes the Util package visible, how can you use it from other
code if not plublic ?
Anyway, you should configure your code analysis tools to exclude generated code
(this plugin or any other). What if you don't use maven code style convention ?
> Generate cleaner (w/r/t checkstyle, findbugs, pmd) *Async Utility class
> -----------------------------------------------------------------------
>
> Key: MGWT-115
> URL: http://jira.codehaus.org/browse/MGWT-115
> Project: Maven 2.x GWT Plugin
> Issue Type: Improvement
> Affects Versions: 2.0
> Reporter: jieryn
> Priority: Minor
> Attachments: cleaner-generate-async-util-class.patch
>
>
> The Util class created during the generateAsync goal causes a lot of warnings
> for common static code analysis tools like Checkstyle, FindBugs, and PMD.
> Attached is a patch against r10656 which cleans up this utility class a bit.
> There still is work to be done where we are redundantly setting the service
> target if the service class already codes a @RemoteServiceRelativePath.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
