Dan Tran wrote:
I would like to promote dita-maven-plugin out of sandbox and cut the
first beta release.
+0, notes:
In case you intend to do the promotion and release in one go, be sure to
update the SVN references and plugin version on the site as well.
The default value for the skip parameter [0] should likely be "false"
instead of "${false}". Also, the since version of this parameter is
1.0-alpha-1, shouldn't that be beta-1?
The project parameter [1] should be annotated with "@readonly".
mvn dependency:analyze reports undeclared dependencies.
The dependency org.codehaus.mojo:truezip-maven-plugin is declared twice.
scm/developerConnection points at an invalid URL.
The file AntOutputConsumer.java has no license header.
The parameter antProperties [2] is annotated with "@since since ...",
note the superfluos/duplicate "since". Same applies for many parameters
of dita:run.
Mojo parameters with expression="${project.*}" should better use
default-value="${project.*}" to query the POM data.
Benjamin
[0] http://mojo.codehaus.org/dita-maven-plugin/chm2web-mojo.html#skip
[1] http://mojo.codehaus.org/dita-maven-plugin/chm2web-mojo.html#project
[2]
http://mojo.codehaus.org/dita-maven-plugin/version-mojo.html#antProperties
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
