[ 
http://jira.codehaus.org/browse/MOJO-1455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=198162#action_198162
 ] 

Robert Scholte commented on MOJO-1455:
--------------------------------------

I don't think we should ever try to configure one file relative to the other 
within the pom. In the pom all paths should be relative to the basedir or 
absolute. If it's required to make the outputPath relative to the setupscript 
we should do this inside the mojo, not in the configuration.

> nsis-maven-plugin ignores that outputFile is relative to setupScript
> --------------------------------------------------------------------
>
>                 Key: MOJO-1455
>                 URL: http://jira.codehaus.org/browse/MOJO-1455
>             Project: Mojo
>          Issue Type: Bug
>          Components: nsis
>            Reporter: Michael Rudolf
>         Attachments: stop-mangling-outputFile.patch
>
>
> NSIS regards the outputPath parameter as relative to the setup script, if it 
> denotes a relative path. Therefore, messing around with it will break NSIS in 
> case the setup script is not in the default location. Example: if the setup 
> script is in src/main/nsis/setup.nsi and the outputPath is given as 
> ../../../target/setup.exe (note that this is relative to the setup script), 
> then the mojo erroneously converts the latter path to target/setup.exe, which 
> will be resolved to src/main/nsis/target/setup.exe and fails due to the 
> non-existence of the target subdirectory inside the nsis directory. Using an 
> absolute path instead of a relative one for the outputPath property will not 
> work either, since it will also be converted to target/setup.exe. Summing up, 
> making the outputPath property relative to the project basedir is wrong, 
> since it is relative to the setup script.
> The attached patch removes the lines converting the outputPath to a relative 
> path in case it is inside the project basedir.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


Reply via email to