[mojo-dev] [jira] Issue Comment Edited: (MGWT-75) Compiler SHOULD skip modules without entry points when modules are autodetected.

[Richard Allen (JIRA)]

    [ 
http://jira.codehaus.org/browse/MGWT-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=202150#action_202150
 ] 

Richard Allen edited comment on MGWT-75 at 12/10/09 1:22 PM:
-------------------------------------------------------------

This fix prevents a target module from being compiled when the target module 
extends another with an entry point. We use this scenario to only compile for a 
single target browser during development. For example, we have a gwt.xml that 
looks like this:

{{MyModule.gwt.xml}}
{code:xml:title=MyModule.gwt.xml}
<module>
  <entry-point class="com.mycompany.MyModule"/>
</module>
{code}

Then another gwt.xml that extends the one above that looks like this:

{{MyModuleFirefox.gwt.xml}}
{code:xml:title=MyModuleFirefox.gwt.xml}
<module>
  <inherits name="com.mycompany.MyModule"/>

  <set-property name="user.agent" value="gecko1_8" />
</module>
{code}

Previous to gwt-maven-plugin 1.2-SNAPSHOT we were able to point to 
{{MyModuleFirefox.gwt.xml}} and get a successful compile. With 1.2-SNAPSHOT, it 
skips the compilation because it doesn't find an entry-point in 
{{MyModuleFirefox.gwt.xml}}.

I confirmed this by commenting out the following {{if}} block in 
{{CompileMojo.compilationRequired()}}.

{code}
if ( gwtModule.getEntryPoints().length == 0 )
{
    // No entry-point, this is a secondary module : compiling this one will fail
    // with '[ERROR] Module has no entry points defined'
    return false;
}
{code}

The gwt-maven-plugin configuration for this build looks like the following, 
where the property {{gwt.module}} is set to {{MyCompanyFirefox.gwt.xml}}:

{code:xml}
<plugin>
  <groupId>org.codehaus.mojo</groupId>
  <artifactId>gwt-maven-plugin</artifactId>
  <version>${gwt.plugin.version}</version>
  <configuration>
    <modules>
      <module>${gwt.module}</module>
    </modules>
    <webappDirectory>${war.build.dir}</webappDirectory>
    <runTarget>${gwt.run.target}</runTarget>
    <style>PRETTY</style>
    <noServer>${gwt.noserver}</noServer>
    <jvm>${env.JVM_32BIT}</jvm>
    <extraJvmArgs>${gwt.extra.jvm.args}</extraJvmArgs>
    <debugPort>${gwt.debug.port}</debugPort>
    <debugSuspend>${gwt.debug.suspend}</debugSuspend>
    <whitelist>${gwt.run.target}</whitelist>
  </configuration>
</plugin>
{code}

      was (Author: richard.allen):
    This fix prevents a target module from being compiled when the target 
module extends another with an entry point. We use this scenario to only 
compile for a single target browser during development. For example, we have a 
gwt.xml that looks like this:

{{MyModule.gwt.xml}}
{code:xml:title=MyModule.gwt.xml}
<module>
  <entry-point class="com.mycompany.MyModule"/>
</module>
{code}

Then another gwt.xml that extends the one above that looks like this:

{{MyModuleFirefox.gwt.xml}}
{code:xml:title=MyModuleFirefox.gwt.xml}
<module>
  <inherits name="com.mycompany.MyModule"/>

  <set-property name="user.agent" value="gecko1_8" />
</module>
{code}

Previous to gwt-maven-plugin 1.2-SNAPSHOT we were able to point to 
{{MyModuleFirefox.gwt.xml}} and get a successful compile. With 1.2-SNAPSHOT, it 
skips the compilation because it doesn't find an entry-point in 
{{MyModuleFirefox.gwt.xml}}.

I confirmed this by commenting out the following {{if}} block in 
{{CompileMojo.compilationRequired()}}.

{code}
if ( gwtModule.getEntryPoints().length == 0 )
{
    // No entry-point, this is a secondary module : compiling this one will fail
    // with '[ERROR] Module has no entry points defined'
    return false;
}
{code}
  
> Compiler SHOULD skip modules without entry points when modules are 
> autodetected.
> --------------------------------------------------------------------------------
>
>                 Key: MGWT-75
>                 URL: http://jira.codehaus.org/browse/MGWT-75
>             Project: Maven 2.x GWT Plugin
>          Issue Type: Wish
>    Affects Versions: 1.1
>            Reporter: Leszek Gruchala
>            Assignee: nicolas de loof
>             Fix For: 1.2
>
>
> The plugin shouldn't think that all modules must have entry points.
> This error is invalid:
> [ERROR] Module has no entry points defined

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email