-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi Trygve, hi everybody,
I have some things to chat about unix-maven-plugin. After about half a year I finally found the time to start digging... Here are some issues to improve or discuss: * There is no component "unix" in JIRA for MOJO. Should we create one? * DebControlParserTest fails to run on windows. I debugged into and found out that it reads the control-files from the disc with windows newlines and then compares them with the strings in the code of the testcase that have \n build in. My suggestion would be to set property svn:eol-style=LF on the according control files to fix this. * Why are you NOT using org.junit.Assert-Methods (at least inside TestUtil)? You are wasting rich IDE support to evaluate the failures of JUnit-tests. If you want to I can send you a patch. Otherwise let me know why your created your on solution. * The code-style is a little bit strage for me but I guess this origins because I am not familiar with functional-java. Are you using a specific fj-IDE? However is it just lazyness that there is hardly any javadoc or comment? Or is the code partially generated? It makes it a little difficult to get into especially because of the compact names you use (If StringF was named, StringFunctions one would get it easier and I personally prefer rich IDE such as Eclipse so I do not care about longer names). Otherwise I might add some comments when I digged through some parts of the code and add it to a potential patch. * Do I get it right that several pieces of code are just fancy ideas but never used in the code (such as chmod and chmodIf, etc.)? I just ask because it confused me (e.g. for chmod I expected that you do this on the vfs rather than native). * A lot more to talk about but not tonight :) Regards Jörg -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAks/zckACgkQmPuec2Dcv/965QCfV+r17P1wXHQl5Qg022oJ+Emy cYsAn20q+zuVPxp0a2oFcdYKoUglc6gg =tSWV -----END PGP SIGNATURE----- --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
