Hi Robert, Thanks a lot for the useful feedback! I'll carefully adress those issues in the next iterations.
Cheers On Wed, Jan 13, 2010 at 7:32 PM, Robert Scholte <[email protected]> wrote: > Hi Julien, > > Pretty impressive to have an account and your first mojo deployed within a > day ;) > > I noticed some small things you might want to fix: > - you already mailed about the absence of (integration) tests. Here are some > links for extra help: > * > http://docs.codehaus.org/display/MAVENUSER/Review+of+Plugin+Testing+Strategies > * http://maven.apache.org/plugin-developers/plugin-testing.html > * references on these pages > - I believe you should remove the project organisation from the pom, so > it'll inherit the Codehaus info. (See > http://mojo.codehaus.org/latex-maven-plugin/project-summary.html). Sure you > can keep the project organisation bound to your member-info. > - the expression you use for latexBuildDir is actually a default-value > (because of it's /latex suffix) > - should buildDir have the @readonly annotation? > - see http://mojo.codehaus.org/latex-maven-plugin/pmd.html (the error is > clear ;) ) see > http://maven.apache.org/plugins/maven-pmd-plugin/examples/targetJdk.html > - try to get rid of all the errors in > http://mojo.codehaus.org/latex-maven-plugin/checkstyle.html ( see > http://maven.apache.org/developers/committer-environment.html#Maven_Code_Style ) > > Good luck!! > > - Robert > > > > ---------------------------------------- >> Date: Wed, 13 Jan 2010 16:45:15 +0100 >> From: [email protected] >> To: [email protected] >> Subject: [mojo-dev] latex-maven-plugin first snapshot published >> >> Hi Team, >> >> I am pleased to announce that I have published a first snapshot of the >> plugin, published its site, and that I have updated the mojo plugins >> lists. >> >> http://mojo.codehaus.org/latex-maven-plugin/ >> >> Cheers >> >> -- >> http://izpack.org/ >> http://jpz-log.info/ >> http://julien.ponge.info/ >> >> --------------------------------------------------------------------- >> To unsubscribe from this list, please visit: >> >> http://xircles.codehaus.org/manage_email >> >> > > ________________________________ > Express yourself instantly with MSN Messenger! MSN Messenger -- http://izpack.org/ http://jpz-log.info/ http://julien.ponge.info/ --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
