[ 
http://jira.codehaus.org/browse/MOJO-1509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=214669#action_214669
 ] 

Kalle Korhonen commented on MOJO-1509:
--------------------------------------

Didn't look too spaghetti to me. I've tested and using it already. This mojo 
offers far fewer options than some other plugins and they still manage to keep 
their code remarkably clean. Subsequent Wagon:remove, wagon:mkdir, 
wagon:upload, wagon:chmod etc. is no better than writing an Ant script for it.

Maybe leave the issue open for now. I'll attach a patch and let the users 
decide.

> Add clean option to wagon:upload
> --------------------------------
>
>                 Key: MOJO-1509
>                 URL: http://jira.codehaus.org/browse/MOJO-1509
>             Project: Mojo
>          Issue Type: Improvement
>          Components: wagon
>         Environment: Affects version 1.0-beta-3
>            Reporter: Kalle Korhonen
>
> Add clean option for wagon:plugin, discussed at: 
> http://www.mail-archive.com/[email protected]/msg15879.html. There was a 
> suggestion to add it as a separate wagon:remove mojo, but my answer to that 
> was:
> "I really don't think a separate wagon:remove mojo is the right answer. After 
> all, the whole is point is to try to capture the commonly desired 
> functionality into a mojo. wagon:remove looks to me dangerously like an Ant 
> task -
> what's next then: wagon:chmod, wagon:mkdir, ...). If it has to be a separate 
> mojo, then it could just as well be something like wagon:command where you 
> can specify the command to execute (like Ant's sshexec), but it could be 
> implemented only for certain protocols so I don't know it shouldn't be part 
> of the wagon plugin anymore. On the contrary, if you are using wagon:upload 
> there's a pretty good chance you want a clean upload, so adding a clean 
> option makes sense even if it can only be implemented for some specific 
> protocols."

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


Reply via email to