[ 
http://jira.codehaus.org/browse/MGWT-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=221862#action_221862
 ] 

nicolas de loof commented on MGWT-170:
--------------------------------------

Because this feature is just a hack !
GWT modules are expected by GWT spec to include java sources in the jar (they 
even don't require to include compiled classes, even this is simplier from IDE 
point of view)
Having maven to support source-jars is a IDE-helper feature, using it for GWT 
compilation does not follow the original design.
Even if I can understand it MAY be simplier for some user that don't care about 
this, you CAN'T expect any dependency to be a valid GWT module (in many case, 
they don't based on limited JRE emulation)

> Find source jars and add them to the classpath when executing the GWT compiler
> ------------------------------------------------------------------------------
>
>                 Key: MGWT-170
>                 URL: http://jira.codehaus.org/browse/MGWT-170
>             Project: Maven 2.x GWT Plugin
>          Issue Type: Improvement
>    Affects Versions: 1.1
>            Reporter: Micah Whitacre
>            Assignee: nicolas de loof
>             Fix For: 1.3
>
>
> When dealing with multiple modules/projects[1], it would be nice to remove 
> the restriction that source code must be bundled inside of the final 
> endstate.  In addition to making the endstates larger it also means making 
> source code more available than a developer/corporation desire.  I started a 
> discussion on the GWT Community group[2] about what the requirements are for 
> the GWT compiler.
> I'd propose that instead of forcing endstates to include the source code you 
> make use of the Maven convention of using separate sources jars.  In my 
> testing I've found that if I have Project A depends on a module represented 
> by ProjectB.  If I configure B to produce the following 2 endstates:
> ProjectB.jar
> ProjectB-sources.jar
> I can then configure Project A to have the following dependencies:
> <dependency>
>   <groupId>org.foo</groupId>
>   <artifactId>projectB</artifactId>
>   <scope>compile</scope>
> </dependency>
> <dependency>
>   <groupId>org.foo</groupId>
>   <artifactId>projectB</artifactId>
>   <scope>provided</scope>
>   <classifier>sources</classifier>
> </dependency>
> This eliminates the need for the final endstates to include code and will 
> also make the GWT compiler happy.  Additionally if the gwt-maven-plugin 
> wanted to make a developer's life really really easy it could download the 
> source jars automatically[3] and attach them to the classpath.
> So the 2 things I propose are:
> 1. enhance the documentation to state the use of sources jars.
> 2. download the source jars automatically and use them to make the gwt 
> compiler happy.
> [1] - http://mojo.codehaus.org/gwt-maven-plugin/user-guide/multiproject.html
> [2] - 
> http://groups.google.com/group/google-web-toolkit/browse_thread/thread/dd3cbefa5cb84372/042e5d9a741f3bdc?lnk=gst&q=Micah#042e5d9a741f3bdc
> [3] - 
> http://stackoverflow.com/questions/1440224/how-can-i-download-maven-artifacts-within-a-plugin

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


Reply via email to