[ 
http://jira.codehaus.org/browse/MHIBERNATE-106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=222851#action_222851
 ] 

Pascal Thivent commented on MHIBERNATE-106:
-------------------------------------------

Thanks for the feedback and... that's awesome! I looked at the new defaults and 
they look great, I'm under the impression that they will allow everything to 
work out-of-the box, which is good for defaults :) I just wonder why 
{{hbm2cfgxml}} doesn't use {{${project.build.directory}}} as destination dir 
(like {{hbm2hbmxml}}) which is also the "expected" value for 
{{configurationfile}}. Is the generated {{hibernate.cfg.xml}} going to be 
copied to {{${project.build.directory}}} at some point? If so, why this extra 
step (I may be missing something obvious). Thanks in advance.

> Use ${project.build.directory}/generated-sources/hibernate3 as default 
> outputDirectory for hbm2java
> ---------------------------------------------------------------------------------------------------
>
>                 Key: MHIBERNATE-106
>                 URL: http://jira.codehaus.org/browse/MHIBERNATE-106
>             Project: Maven 2.x Hibernate Plugin
>          Issue Type: Improvement
>          Components: hbm2java
>    Affects Versions: 2.0-alpha-2, 2.0, 2.1, 2.2, 3.0, 2.3
>            Reporter: Pascal Thivent
>            Assignee: Johann Reyes
>            Priority: Minor
>
> AFAIK, the Maven convention is to use 
> {{${project.build.directory}/generated-sources/<generator-name>}} for 
> generated code. This is just a convention ([inherited from Maven 
> 1|http://www.mail-archive.com/[email protected]/msg77749.html]) but I 
> know that IDEs still rely on it:
> - see [this page|http://www.jetbrains.net/devnet/thread/283102] for IDEA 
> - or [this one|http://wiki.netbeans.org/MavenBestPractices] for NetBeans
> Following it would thus be handy when importing projects relying on code 
> generation. And from what I've seen while searching for an existing issue, it 
> seems that lot of people are actually using this convention so I have the 
> feeling that making it the default would make sense.
> I understand that such a change would break the consistency with the output 
> directories of other components but... it would be more consistent with the 
> way many other plugins work.
> What do you think?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


Reply via email to