using revisionOnScmFailure fails on getScmBranch when using javasvn
-------------------------------------------------------------------
Key: MOJO-1539
URL: http://jira.codehaus.org/browse/MOJO-1539
Project: Mojo
Issue Type: Bug
Components: buildnumber
Affects Versions: buildnumber-maven-plugin-1.0-beta-4
Environment: Maven 2.2.1, Windows XP, Java 1.6.0_03-b05
Reporter: Chris Blackburn
Priority: Minor
Attachments: getScmBranchPatch.txt
The revisionOnScmFailure works great when javasvn is NOT used as the provider
implementation.
Walking through the code, it appears that in the getScmBranch() method, an
ScmException is being thrown when using javasvn, but not with standard svn.
There is currently functionality in the getRevision() method where if a
ScmException is thrown, the catch block will check to see if
revisionOnScmFailure is set, and if so return the specified version.
I think the same functionality should be implemented in the getScmBranch()
method and simply return DEFAULT_BRANCH_NAME as done elsewhere.
I have attached a simple patch that includes this functionality for your
review. Please let me know if there is anything else I can provide.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
