[
http://jira.codehaus.org/browse/MAXISTOOLS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=230804#action_230804
]
Dennis Lundberg edited comment on MAXISTOOLS-38 at 8/4/10 2:54 AM:
-------------------------------------------------------------------
Pasting Benjamin's suggested todo list from the e-mail thread here for easier
access:
"mvn docck:check" reports quite a dozen of mojo parameters which have no
documentation. (Partly done. Still 5 more parameters to fix. Also need to add a
FAQ.)
Also, the POM is missing a <license> element (seems to be ASL 2.0). (*FIXED*)
"mvn dependency:analyze" shows some oddities with the Maven dependencies.
(*FIXED*)
The site descriptor can be trimmed down, e.g. banners and links are
inherited. (*FIXED*)
The POM snippets on the plugin's usage/example pages don't include a
<version> element as suggested by best practices. (*FIXED*)
Furthermore, the POM snippet on the usage page does not even give a
<groupId> which won't work since the default value is
"org.apache.maven.plugins". (*FIXED*)
The mojo parameters
- project in AdminMojo
- project in Java2WSDLMojo
- project in WSDL2JavaMojo
- pluginArtifacts in WSDL2JavaMojo
should be marked as @readonly to prevent user confusion. (*FIXED*)
The mojo parameter
- timestampDirectory in WSDL2JavaMojo
defaults to "${basedir}/target" which is better described by
"${project.build.directory}". (*FIXED*)
Likewise, the mojo parameter
- classesDirectory in Java2WSDLMojo
defaults to "${project.build.directory}/classes" which matches
"${project.build.outputDirectory}". (*FIXED*)
The method getRuntimeClasspath() in Java2WSDLMojo looks strange. First,
it neglects class path ordering as specified in the POM by storing the
paths in a HashSet. Second, the method queries
getRuntimeClasspathElements() although the mojo is only annotated with
"@requiresDependencyResolution compile", i.e. the plugin will usually
not see anything beyond compile scope. (*FIXED*)
The mojo parameter
- staleMillis in WSDL2JavaMojo
is never read (c.f. PMD report). Looks like a missing call to
WSDL2JavaPlugin.setStaleMillis(). (Not fixed)
was (Author: dennislundberg):
Pasting Benjamin's suggested todo list from the e-mail thread here for
easier access:
"mvn docck:check" reports quite a dozen of mojo parameters which have no
documentation.
Also, the POM is missing a <license> element (seems to be ASL 2.0).
"mvn dependency:analyze" shows some oddities with the Maven dependencies.
The site descriptor can be trimmed down, e.g. banners and links are
inherited.
The POM snippets on the plugin's usage/example pages don't include a
<version> element as suggested by best practices.
Furthermore, the POM snippet on the usage page does not even give a
<groupId> which won't work since the default value is
"org.apache.maven.plugins".
The mojo parameters
- project in AdminMojo
- project in Java2WSDLMojo
- project in WSDL2JavaMojo
- pluginArtifacts in WSDL2JavaMojo
should be marked as @readonly to prevent user confusion.
The mojo parameter
- timestampDirectory in WSDL2JavaMojo
defaults to "${basedir}/target" which is better described by
"${project.build.directory}".
Likewise, the mojo parameter
- classesDirectory in Java2WSDLMojo
defaults to "${project.build.directory}/classes" which matches
"${project.build.outputDirectory}".
The method getRuntimeClasspath() in Java2WSDLMojo looks strange. First,
it neglects class path ordering as specified in the POM by storing the
paths in a HashSet. Second, the method queries
getRuntimeClasspathElements() although the mojo is only annotated with
"@requiresDependencyResolution compile", i.e. the plugin will usually
not see anything beyond compile scope.
The mojo parameter
- staleMillis in WSDL2JavaMojo
is never read (c.f. PMD report). Looks like a missing call to
WSDL2JavaPlugin.setStaleMillis().
> Improve documentation and cleanup code
> --------------------------------------
>
> Key: MAXISTOOLS-38
> URL: http://jira.codehaus.org/browse/MAXISTOOLS-38
> Project: Maven 2.x Axis Tools Plugin
> Issue Type: Improvement
> Affects Versions: 1.0, 1.1
> Environment: N/A
> Reporter: David J. M. Karlsen
>
> Reference:
> http://www.nabble.com/-Vote--Release-axistools-maven-plugin-1.2-td20802058.html.
> Cleanup documentation in general.
> Also cleanup code - some weirdness where a lot of properties are defined in
> an interface and propagated.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
