+1, no regression found on my build -D
On Sun, Aug 8, 2010 at 2:17 AM, Robert Scholte <[email protected]> wrote: > Nice work! > > +1 for me > > - Robert > >> Date: Sun, 8 Aug 2010 10:16:30 +0200 >> From: [email protected] >> To: [email protected] >> Subject: Re: [mojo-dev] [VOTE] Release Axis Tools Maven Plugin 1.4 >> >> On 2010-08-07 13:27, Robert Scholte wrote: >> > I don't know axis (and this plugin) well enough to criticize the actual >> > implementation, but I have the following remarks: >> > - the pom isn't using the latest mojo-parent (23 instead of 24) >> > - (If we're touching the pom, we should also add just one property with >> > the mavenVersion which can be used as prerequisite and all maven-deps) >> > - The parameters configOutputDirectory, isServerConfig and project of >> > the AdminMojo use expression instead of default-value. Most parameters >> > of the other classes seems to use "expression" as it should, but every >> > now and than it should be using default-value. >> > - checkstyle report shows 51 errors. Apart from some long lines, wrong >> > operator wraps it looks like all files start with an old version of the >> > license-text. >> > - findbugs is misleading. Almost every message has to do with variable >> > injection, something findbugs can't detect. Should this report be added? >> >> Thanks a lot for your review Robert. >> >> I've fixed the above, except for 3 remaining Checkstyle errors, which >> were not fixable simply reformating the code. An upgrade of >> findbugs-plugin eliminated most of the bogus errors. This requires Java >> 5 to be able to generate the report, which I documented in the POM. But >> I suspect this is a reasonable requirement these days. >> >> > - Odd, the taglist-report counts 3 lines with todo's, but it's linked to >> > the wrong xref-page. Look like a bug in the taglist-m-p. Anyhow, I don't >> > think these line are todo's, buit just comments. >> >> The links in the taglist report looks fine for me and points to real >> todos in the JXR page. Strange... >> >> > >> > It's all just a matter of cleaning up, but I think we should do it >> > before releasing. I could pick up some of these things. >> > >> > Some positive things: >> > - junit and integration tests pass >> > - dependency:analyze is clean >> > >> > cheers, Robert >> > >> >> Date: Sat, 7 Aug 2010 11:42:52 +0200 >> >> From: [email protected] >> >> To: [email protected] >> >> Subject: [mojo-dev] [VOTE] Release Axis Tools Maven Plugin 1.4 >> >> >> >> Hi, >> >> >> >> I'd like to release version 1.4 of Axis Tools Maven Plugin. >> >> A 1.4-SNAPSHOT has been deployed, for testing purposes. >> >> >> >> The release notes are here: >> >> >> > >> > http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11697&version=14915 >> >> >> >> [ ] +1 >> >> [ ] 0 >> >> [ ] -1 >> >> >> >> The vote is open for 72 hours and will succeed by lazy consensus. >> >> >> >> -- >> >> Dennis Lundberg >> >> >> >> --------------------------------------------------------------------- >> >> To unsubscribe from this list, please visit: >> >> >> >> http://xircles.codehaus.org/manage_email >> >> >> >> >> >> >> -- >> Dennis Lundberg >> >> --------------------------------------------------------------------- >> To unsubscribe from this list, please visit: >> >> http://xircles.codehaus.org/manage_email >> >> > --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
