[
http://jira.codehaus.org/browse/MNBMODULE-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=233573#action_233573
]
Milos Kleint commented on MNBMODULE-92:
---------------------------------------
jesse, I have applied you patch but then realized it's flawed and reverted..
the problem with ${project.parent.artifactId} is that it does not scale
properly, in some setups users separate the root aggregator from the parent (we
do at sonatype, mojo project does as well) so you end up with mojo-parent as
branding token and cluster..
which leads to the other problem I forgot about.. the branding token or cluster
names have some characters prohibited (or just not working, can't recall) eg -
character caused trouble if I recall correctly.. this char is quite frequent
though in artifact ids.. that's why I picked a hardwired value
> Poor choice of <cluster> / <brandingToken> in archetype
> -------------------------------------------------------
>
> Key: MNBMODULE-92
> URL: http://jira.codehaus.org/browse/MNBMODULE-92
> Project: Maven 2.x Netbeans Module Plugin
> Issue Type: Bug
> Environment:
> {{org.codehaus.mojo.archetypes:netbeans-platform-app-archetype:1.3-SNAPSHOT}}
> Reporter: Jesse Glick
> Assignee: Milos Kleint
> Attachments: mojo-nbm-cluster-branding.diff
>
>
> (Classifying as a "major" bug despite workaround due to poor initial user
> experience. Also tentatively filing here since {{MARCHETYPES}} has no
> apparent component for NBM-related archetypes.)
> The archetype defines
> {code:xml}
> <cluster>foobar</cluster>
> <brandingToken>foo</brandingToken>
> {code}
> Both of these values should likely use the base artifact ID, e.g.
> {code:xml}
> <cluster>${artifactId}</cluster>
> <brandingToken>${artifactId}</brandingToken>
> {code}
> This would match the behavior of the Ant-based template and look less sloppy.
> It would be nice to be able to make the cluster & branding token by default
> track {{project.artifactId}} for the parent POM but this does not work as
> written; the properties seem to be evaluated within {{application/pom.xml}}
> and so the result is simply {{application}}. {{project.parent.artifactId}}
> does seem to work.
> Note that escaping {{$}} in the template is recommended to avoid
> {{org.apache.velocity.runtime.exception.ReferenceException}} warnings during
> archetype instantiation, but this would be a separate bug (it is already
> broken).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
