Thank you Evgeny and Robert for your feedback. The vote succeeds with lazy consensus.
> > A few remarks, which can be fix in beta-3 > - the checkstyle-reports shows me still some errors, which should be easy > to fix. Most of them have to do with whitespaces and operators. > Ok I'll fix them, but it sounds strange, I used the Idea codestyle conf provided in the maven doc. > - you've written your own method for checking version-ranges. I'd suggest > to use VersionRange[1], which should be much more solid and much esier to > expand if there are more versions to check for. > This method just checks if sonar version is less than 2.2. It's a really simple method because all past versions are well known. There's no need to to be more flexible. The unit test checks all possible use cases. Simon ------------------------------ > From: [email protected] > Date: Fri, 10 Sep 2010 00:10:35 +0400 > > To: [email protected] > Subject: Re: [mojo-dev] [VOTE] Sonar maven plugin 1.0-beta-2 > > +1 > > It works as expected - I've tested following environments : Sonar 2.2 and > 2.1 with and without Nexus + from Hudson Sonar Plugin > > On Thu, Sep 9, 2010 at 20:17, Simon Brandhof < > [email protected]> wrote: > > It's ok now, we can restart the vote. The staging repository is > https://nexus.codehaus.org/content/repositories/orgcodehausmojo-018/. > This improvement is quite complex to test. It requires an environment with > a maven proxy and sonar >= 2.2. Analyzing a project should work without > configuring anything in the proxy. > > Thank you Robert and Benjamin for your precious help. > > On Thu, Sep 9, 2010 at 4:40 PM, Benjamin Bentmann < > [email protected]> wrote: > > Simon Brandhof wrote: > > Something is missing in documentation : when the mojo version should be > updated in mojo site ? I suppose before staging the release. > > > I don't see a good reason to do so before the release has actually > passed/completed. > > > Benjamin > > > --------------------------------------------------------------------- > To unsubscribe from this list, please visit: > > http://xircles.codehaus.org/manage_email > > > > > > > -- > Best regards, > Evgeny Mandrikov aka Godin <http://godin.net.ru> > http://twitter.com/_godin_ >
