Hi Mark,
Revision 12564<http://fisheye.codehaus.org/changelog/mojo/?cs=12564> Author mark Date 2010-09-15 11:09:11 -0500 (Wed, 15 Sep 2010)Log Message [MOJO-1570<http://jira.codehaus.org/secure/ViewIssue.jspa?key=MOJO-1570>] [m3] Apt fails to include plugin dependencies in classpath Use compile and runtime scoped plugin dependencies in the apt classpath. Modified Paths * trunk/mojo/apt-maven-plugin/src/main/java/org/codehaus/mojo/apt/MavenProjectUtils.java <#trunkmojoaptmavenpluginsrcmainjavaorgcodehausmojoaptMavenProjectUtilsjava> Diff Modified: trunk/mojo/apt-maven-plugin/src/main/java/org/codehaus/mojo/apt/MavenProjectUtils.java (12563 => 12564) --- trunk/mojo/apt-maven-plugin/src/main/java/org/codehaus/mojo/apt/MavenProjectUtils.java 2010-09-15 15:20:07 UTC (rev 12563) +++ trunk/mojo/apt-maven-plugin/src/main/java/org/codehaus/mojo/apt/MavenProjectUtils.java 2010-09-15 16:09:11 UTC (rev 12564) @@ -74,8 +74,7 @@ { // TODO: let the scope handler deal with this if ( Artifact.SCOPE_COMPILE.equals( artifact.getScope() ) - || Artifact.SCOPE_PROVIDED.equals( artifact.getScope() ) - || Artifact.SCOPE_SYSTEM.equals( artifact.getScope() ) ) + || Artifact.SCOPE_RUNTIME.equals( artifact.getScope() ) ) { addArtifactPath( project, artifact, list ); }
Maybe I miss something but won't the removal of provided and in particular system scope potentially break the plugin?
Also, what exactly is the purpose of this scope filtering? The only invocation of this method I could find was from AbstractAptMojo.getPluginClasspathElements() which passes in the plugin artifacts. Those artifacts denote the plugin runtime, what's the need to filter those by scope, in particular if your intention is to include all of them?
Benjamin --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
