[ 
http://jira.codehaus.org/browse/MTOMCAT-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=237689#action_237689
 ] 

Mark Michaelis commented on MTOMCAT-62:
---------------------------------------

Actually it will require some refactoring... and perhaps an extra release as 
the way to embed the Tomcat completely changed. A good start is the blog post 
by Coppery Keen Claws: [Embedding Tomcat 
7|http://www.copperykeenclaws.com/embedding-tomcat-7/].

As first start the dependencies need to be updated. Most artifacts now have a 
_tomcat-_ prefix and one is even gone. {{tomcat-jasper}} even requires an 
exclusion:

{code:xml}
<project>
  [...]
  <properties>
    [...]
    <tomcat7x.version>7.0.2</tomcat7x.version>
    [...]
  </properties>
  [...]
  <dependencies>
    [...]
    <dependency>
      <groupId>org.apache.tomcat</groupId>
      <artifactId>tomcat-catalina</artifactId>
      <version>${tomcat7x.version}</version>
    </dependency>
    <dependency>
      <groupId>org.apache.tomcat</groupId>
      <artifactId>tomcat-catalina-ha</artifactId>
      <version>${tomcat7x.version}</version>
      <scope>runtime</scope>
    </dependency>
    <dependency>
      <groupId>org.apache.tomcat</groupId>
      <artifactId>tomcat-tribes</artifactId>
      <version>${tomcat7x.version}</version>
      <scope>runtime</scope>
    </dependency>
    <dependency>
      <groupId>org.apache.tomcat</groupId>
      <artifactId>tomcat-el-api</artifactId>
      <version>${tomcat7x.version}</version>
      <scope>runtime</scope>
    </dependency>
    <dependency>
      <groupId>org.apache.tomcat</groupId>
      <artifactId>tomcat-jasper</artifactId>
      <version>${tomcat7x.version}</version>
      <scope>runtime</scope>
      <exclusions>
        <!-- org.eclipse.jdt not available on Maven Repos -->
        <!-- see also: http://www.copperykeenclaws.com/embedding-tomcat-7/ -->
        <exclusion>
          <groupId>org.eclipse.jdt</groupId>
          <artifactId>ecj</artifactId>
        </exclusion>
      </exclusions>
    </dependency>
    <!-- Replace org.eclipse.jdt:ecj:jar:3.6 dependency which comes with 
tomcat-jasper -->
    <dependency>
      <groupId>org.eclipse.jdt.core.compiler</groupId>
      <artifactId>ecj</artifactId>
      <version>3.5.1</version>
      <scope>runtime</scope>
    </dependency>
    <dependency>
      <groupId>org.apache.tomcat</groupId>
      <artifactId>tomcat-jasper-el</artifactId>
      <version>${tomcat7x.version}</version>
      <scope>runtime</scope>
    </dependency>
    <!-- No jasper-jdt anylonger -->
    <dependency>
      <groupId>org.apache.tomcat</groupId>
      <artifactId>tomcat-jsp-api</artifactId>
      <version>${tomcat7x.version}</version>
      <scope>runtime</scope>
    </dependency>
    <dependency>
      <groupId>org.apache.tomcat</groupId>
      <artifactId>tomcat-servlet-api</artifactId>
      <version>${tomcat7x.version}</version>
      <scope>runtime</scope>
    </dependency>
    <dependency>
      <groupId>org.apache.tomcat</groupId>
      <artifactId>tomcat-coyote</artifactId>
      <version>${tomcat7x.version}</version>
      <scope>runtime</scope>
    </dependency>
    <dependency>
      <groupId>org.apache.tomcat</groupId>
      <artifactId>tomcat-dbcp</artifactId>
      <version>${tomcat7x.version}</version>
      <scope>runtime</scope>
    </dependency>
    [...]
  </dependencies>
  [...]
</project>
{code}

Actually this is not the only thing. The Embedded Class is deprecated and 
should be replaced by Tomcat but this is configured completely differently.

My suggestion: Split the workspace into multiple modules where one is for 
Tomcat 6x the other one for Tomcat 7x. To ensure that everything is working 
some integration tests would be handy.

> Support Tomcat 7
> ----------------
>
>                 Key: MTOMCAT-62
>                 URL: http://jira.codehaus.org/browse/MTOMCAT-62
>             Project: Maven 2.x Tomcat Plugin
>          Issue Type: Improvement
>    Affects Versions: 1.1
>            Reporter: Travis
>
> Please support Tomcat 7.
> BTW.  There are several maven tomcat plugins that support Tomcat 7:
> http://code.google.com/p/t7mp/
> http://cargo.codehaus.org/

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


Reply via email to