[
http://jira.codehaus.org/browse/MNBMODULE-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=241706#action_241706
]
Gabriele Kahlout edited comment on MNBMODULE-109 at 11/1/10 3:48 PM:
---------------------------------------------------------------------
I just meant that the patch should be more than one line. Precisely:
-<jnlp spec="1.0+" codebase="${jnlp.codebase}">
+<jnlp spec="1.0+" codebase="${jnlp.codebase}" href="branding.jnlp">
-<jnlp spec="1.0+" codebase="${jnlp.codebase}">
+<jnlp spec="1.0+" codebase="${jnlp.codebase}" href="${branding.token}.jnlp">
These are not strictly necessary (I think Sun removed their requirement in
1.6.18, but then rolledback in 1.6.2X). Anyway all 1.6 versions like it.
In addition to the 1-line you picked up (I wrote it as two lines, one inline
initialization, and one method call).
Let me know if this is not clear enough, and I'll resubmit the path to do
exactly the above.
was (Author: simaptico):
I just meant that the patch should be more than one line. Precisely:
-<jnlp spec="1.0+" codebase="${jnlp.codebase}">
+<jnlp spec="1.0+" codebase="${jnlp.codebase}" href="branding.jnlp">
-<jnlp spec="1.0+" codebase="${jnlp.codebase}">
+<jnlp spec="1.0+" codebase="${jnlp.codebase}" href="${branding.token}.jnlp">
These are not strictly necessary (I think Sun removed their requirement in
1.6.18, but then rolledback in 1.6.2X). Anyway all 1.6 versions like it.
In addition to the 1-line you picked up (I wrote it as two lines, one inline
initialization, and one method call).
> ability to change the application jnlp master.jnlp to a meaningful name
> -----------------------------------------------------------------------
>
> Key: MNBMODULE-109
> URL: http://jira.codehaus.org/browse/MNBMODULE-109
> Project: Maven NetBeans Module Plugin
> Issue Type: Improvement
> Affects Versions: 3.3
> Environment: java web start
> Reporter: Gabriele Kahlout
> Assignee: Jesse Glick
> Fix For: 3.4
>
> Attachments: -nomasterjnlp.diff
>
>
> I thought changing the parameter name in:
>
> <masterJnlpFile>${masterJnlp}</masterJnlpFile>
> and in the href attribute in the file itself would do the trick, but
> apparently no, master.jnlp is hard-coded.
> This makes it harder for users to find the file (who's master?).
> Besides, using the default as the brandingToken (as opposed to 'master')
> would be more consistent.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
