[ 
http://jira.codehaus.org/browse/MOJO-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=246318#action_246318
 ] 

Juan Pablo Santos Rodríguez commented on MOJO-1402:
---------------------------------------------------

Also, if you apply filtering to files reached by native2ascii plugin, 
${project.build.sourceEncoding} is applied to those files when filtering, so 
there is a chance they get double encoded if filtering is enabled.

Filtering takes place on process-resources phase while native2ascii plugin 
takes place on generate-resources phase. Suggested fix goes this way:
- make default phase compile, as this is the only way to enable filtering and 
the native2ascii-maven-plugin without the double encoding issue.
  + By doing this, we need to change src default value, to read filtered files 
from target/classes instead of src/main/native2ascii
  + Another side-effect is that we don't need to add src File to project's 
resources (which should fix issue http://jira.codehaus.org/browse/MOJO-1166)
  + Last side-effect: if src is default-ed to target/classes, native2ascii-ed 
files should be generated on another dir so, once they've been native2ascii-ed, 
they can be copied back to the initial src dir.

Patch following shortly.


> native2ascii-maven-plugin doesn't support setting filtering of the produced 
> resources
> -------------------------------------------------------------------------------------
>
>                 Key: MOJO-1402
>                 URL: http://jira.codehaus.org/browse/MOJO-1402
>             Project: Mojo
>          Issue Type: Bug
>          Components: native2ascii
>            Reporter: Jonas Bergvall
>
> The native2ascii plugin adds a resource to the project by itself. There is no 
> way to specify that this resource should be filtered.
> You can define a resource in the pom the usual way and configure it to be 
> filtered. 
> This will however case eclipse:eclipse to fail when it tries to merge the 
> resources as they have different filtering properties.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


Reply via email to