On 12/09/2011, at 5:37 PM, Anders Hammar wrote:

> 
> I read it as the jira project should be created first and info
> included in the pom. That will make the info on the site correct.

Project file updated to reflect the component's URL:

http://jira.codehaus.org/browse/MJSLINT

>> Hmmm. OK re bread crumb. On the JSLint subject, I really hoped that the 
>> first paragraph did just that; there is a hyper link there under "JavaScript 
>> code quality control". Is this not enough?
> 
> Maybe change to "This plugin brings the JSLint JavaScript code quality
> control tool capabilities…"?
Done.

> 
>>> * The index pages says the plugin is still in sandbox. It's not.
>> Fair enough - but won't the page get updated with 1.0.1-SNAPSHOT as soon as 
>> I release a snapshot again i.e. should it hold up the release of the plugin?
> 
> No. It stays on the last released version. So 1.0.0 is what people
> will see and therefore it's important to get things right before
> releasing.
Thanks for the clarifications. References to sandbox also removed.

> 
>>> * The pom overrides the site plugin version declared by mojo-parent. Why?
>> From memory I believe that this was because I wanted to use 
>> doxia-module-confluence (my site documentation is in Confluence). When 
>> declaring plugins I understand that best practice is to specify a plugin's 
>> version.
> 
> If you just want to add a config (or dependency), you don't have to
> override the version. But possibly your config requires an older
> version of the plugin?
> In my opinion, the more standard mojo config we have the better. Solve
> it once, use everywhere kind of. But there might be places where this
> simply doesn't work.
> 
Fixed. Site plugin version now unspecified in POM. 

I've now re-released the plugin as 1.0.1 and shall re-start the vote shortly.

Kind regards,
Christopher

Reply via email to