Hi Robert, Thanks for feedback.
Indeed - documentation requires some cleanup. And in fact I did not perform changes for docs in this version. But I suppose that current one is ok at least until plugin in sandbox. And I agree about workDir, but don't think that this really critical to stop vote. Or I should treat your email as minus one? And restart process? ;) On Sat, Nov 5, 2011 at 14:23, Robert Scholte <[email protected]> wrote: > Hi Evgeny, > > The documentation needs some improvements, but you can move that to the > next release. > - The usage-page [1] has no plugin-section with can be copied 1 on 1 to a > project pom. The [...] should be removed. Start with a minimal > configuration and add a paragraph for extra configuration options. And > refer to the native2ascii-goal [2] > - The native2ascii goal page[2] says all parameters are optional. Even > though some have default values I guess some up theme are actually required. > - Checkstyle still has a few errors > > A quick review on the code: > - if there's no workdirectory, you should at least log (debug/info) why > the goal isn't executed. > > -Robert > > [1] http://mojo.codehaus.org/native2ascii-maven-plugin/usage.html > [2] > http://mojo.codehaus.org/native2ascii-maven-plugin/native2ascii-mojo.html > [3] http://mojo.codehaus.org/native2ascii-maven-plugin/checkstyle.html > [4] > http://mojo.codehaus.org/native2ascii-maven-plugin/xref/org/codehaus/mojo/native2ascii/Native2AsciiMojo.html#84 > > ------------------------------ > From: [email protected] > Date: Sat, 5 Nov 2011 09:40:01 +0100 > To: [email protected] > Subject: Re: [mojo-dev] [VOTE] Release Native2Ascii Maven Plugin version > 1.0-beta-1 > > > I forgot to say that I successfully tested with Maven 2.0.11, 2.2.1 and > 3.0.3. > > > On 5 November 2011 09:35, Simon Brandhof <[email protected]> wrote: > > Hi Evgeny, > > Type of the property <includes> has changed. It requires now to have > <include> elements, whereas it's not the case in v.1.0-alpha-1. For > example <includes>**/*.properties</includes> must be converted > to <includes><include>**/*.properties</include></includes>. > > It's ok for me to keep this new behavior, that is more consistent with > other plugins, but I think that a JIRA issue should be created. > > Else everything works well with Oracle JDK 6. I did not test with other > vendors/versions. > +1 > > Simon > > > On 4 November 2011 19:40, Timothy Astle <[email protected]> wrote: > > +1 > > Looking forward to using this! > > Tim > > On 04/11/2011 3:06 PM, Evgeny Mandrikov wrote: > > Hi all, > > I'd like to release Native2Ascii Maven Plugin version 1.0-beta-1. > > This plugin converts files with characters in any supported character > encoding to one with ASCII and/or Unicode escapes. > > In this version plugin was completely rewritten in order to simplify > configuration and allow usage with IBM JDK and Oracle JDK 1.7. For more > details see http://jira.codehaus.org/browse/MOJO-1768 > > *7 issues have been solved* > http://jira.codehaus.org/browse/MOJO/fixforversion/18059 > > *There are still a couple of issues left* > http://jira.codehaus.org/browse/MOJO/component/12536 > * > * > Staging Repositories > General: https://nexus.codehaus.org/content/groups/staging/ > Exclusive: > https://nexus.codehaus.org/content/repositories/orgcodehausmojo-002/ > > *Site* > http://mojo.codehaus.org/native2ascii-maven-plugin/ > * > * > *The vote is open for 72 hours and will succeed by lazy consensus.* > * > * > [ ] +1 > [ ] +0 > [ ] -1 > > *Release early, release often!* > * > * > > -- > Best regards, > Evgeny Mandrikov aka Godin <http://godin.net.ru> > http://twitter.com/_godin_ > > > -- > Timothy Astle, BCS > Web Development Manager > > *CARIS* <http://www.caris.com> > 115 Waggoners Lane > Fredericton, New Brunswick > Canada E3B 2L4 > Tel: +1.506.458.8533 Fax: +1.506.459.3849 > www.caris.com *Join us for CARIS 2012 — Exploration and Discovery* > June 25–28, 2012, Vancouver, British Columbia, Canada > Visit www.caris.com/caris2012 for details today > *Connect with CARIS* > Twitter <http://www.twitter.com/CARIS_GIS> | > LinkedIn<http://www.linkedin.com/groups?mostPopular=&gid=3217878>| > Facebook<http://www.facebook.com/pages/CARIS-The-Marine-GIS-Experts/123907500987669?v=app_4949752878>| > YouTube <http://www.youtube.com/user/CARISGIS> > > Download your free copy of CARIS Easy View today! > www.caris.com/easyview > > _________________________________________________________________________ > This email and any files transmitted with it are confidential and intended > only for the addressee(s). If you are not the intended recipient(s) please > notify us by email reply. You should not use, disclose, distribute or copy > this communication if received in error. > > Any views or opinions expressed in this email are solely those of the > author and do not necessarily represent those of the company. No binding > contract will result from this email until such time as a written document > is signed on behalf of the company. > > > > -- Best regards, Evgeny Mandrikov aka Godin <http://godin.net.ru> http://twitter.com/_godin_
