[ 
https://jira.codehaus.org/browse/MOJO-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=283327#comment-283327
 ] 

Robert Scholte commented on MOJO-1773:
--------------------------------------

If the rule finds two duplicate classes and the first class is more recent then 
the second one there still shouldn't be a problem if we trust backwards 
compatibility.
Actually, that's what Maven does too when it resolves 2 transitive jars with 
different versions: it'll use the first one even though the second one was used 
for compiling the other jar.
So I still think we just should warn for duplicate classes even though they 
would be the same.
(And I haven't found a simple API change to use Class A as reference class, B 
being the same and C being differrent)


> BanDuplicateClasses should have option to allow identical duplicates
> --------------------------------------------------------------------
>
>                 Key: MOJO-1773
>                 URL: https://jira.codehaus.org/browse/MOJO-1773
>             Project: Mojo
>          Issue Type: Bug
>          Components: extra-enforcer-rules
>    Affects Versions: extra-enforcer-rules-1.0-alpha-2
>            Reporter: Ian Robertson
>
> An unfortunate trend in some projects is to have two versions of a module, 
> one marked -core, and one marked -all. The -all module is a strict superset 
> of the -core. I would like to add an option that would allow byte-for-byte 
> identical duplicates if none of the packages in questio are sealed. To 
> minimize overhead, sameness checks would be performed only after duplicates 
> were detected.
> I would propose that the property name be:
>  private boolean allowIdenticalyDuplicates

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


Reply via email to