[ 
https://jira.codehaus.org/browse/MOJO-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=283357#comment-283357
 ] 

Mirko Friedenhagen edited comment on MOJO-1756 at 11/13/11 1:32 PM:
--------------------------------------------------------------------

I integrated the patch in SVN and committed it in 
https://svn.codehaus.org/mojo/trunk/sandbox/ckjm-maven-plugin@15109.
@Wayne: I see you decided to use the Apache license. The mojo pages state that 
we should use the MIT license to be compatible with GPL.

      was (Author: mfriedenhagen):
    I integrated the patch in SVN and committed it in SVN.
@Wayne: I see you decided to use the Apache license. The mojo pages state that 
we should use the MIT license to be compatible with GPL.
  
> Hopefully improved version of the ckjm-maven-plugin
> ---------------------------------------------------
>
>                 Key: MOJO-1756
>                 URL: https://jira.codehaus.org/browse/MOJO-1756
>             Project: Mojo
>          Issue Type: Improvement
>            Reporter: Mirko Friedenhagen
>         Attachments: ckjm-maven-plugin.patch
>
>
> As discussed with Wayne on the dev mailing list:
> - I currently host my fork on 
> https://bitbucket.org/mfriedenhagen/ckjm-maven-plugin, sample output may be 
> found at http://huschteguzzel.de/hudson/job/ckjm-maven-plugin/site/ckjm.html
> - I tried to minimize the number of checkstyle warnings, however I am no big 
> fan of documenting every private member with a speaking name :-) Coverage 
> (>90%) and Findbugs (0) should be fine. 
> {quote}
> On Wed, Oct 12, 2011 at 00:24, Wayne Fay <[email protected]> wrote:
> >> this sandbox plugin never made it to a released version. Ages ago I
> > ...
> >> What would be the best way to get my changes back (I read
> >> http://mojo.codehaus.org/development/guidelines.html and several other
> >> pages. I could attach a patch to a issue in the MOJO project).
> >
> > Hey Mirko,
> >
> > I wrote the plugin initially but then I never really saw much interest
> > in it which is why it never made it out of the sandbox. If you want to
> > attach a patch to a MOJO issue, I'd be happy to review it and merge it
> > in. We can also talk more seriously about a release in the "near"
> > future if there are people who genuinely are interested in it.
> Hello Wayne,
> I want to give the plugin a try in our company. I will submit a MOJO
> issue, then. I will supply a git-compatible patch. I am afraid, I have
> changed existing tabs to spaces in some places, though this seems to
> be dictated by the style guide anyway :-).
> {quote}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


Reply via email to