[ 
https://jira.codehaus.org/browse/MNBMODULE-150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=283494#comment-283494
 ] 

Jesse Glick commented on MNBMODULE-150:
---------------------------------------

Patch as written is not right since it can result in manifests like this:

{code}
OpenIDE-Module-Specification-Version: 1.0
OpenIDE-Module-Implementation-Version: 1.0-201111151046
OpenIDE-Module-Build-Version: 201111151546
{code}

I can refine it to make the times match. Looks to be a timezone issue. 
(Probably the code was already wrong but it less commonly mattered.)

Two notes:

1. Implementation versions are ignored by Auto Update (except for verifying 
implementation dependencies), so with or without this patch you cannot "push" 
updated modules simply by using snapshot versions. 
http://wiki.netbeans.org/MavenNBM4#Versioning and 
http://wiki.netbeans.org/AggregatingUC#Version-aware_push may be of interest as 
proposals, but in the meantime if you want to deploy new versions of a module 
to an update site you must really increment the project version (e.g. using 
{{maven-release-plugin}}).

2. This patch will make it hard to work in a reactor with internal 
implementation dependencies unless the upstream module explicitly declares a 
particular implementation version (typically an integer), as any rebuild of the 
upstream module would make the downstream module unloadable unless also rebuilt.

> Incorrect implementation version in snapshot modules
> ----------------------------------------------------
>
>                 Key: MNBMODULE-150
>                 URL: https://jira.codehaus.org/browse/MNBMODULE-150
>             Project: Maven NetBeans Module Plugin
>          Issue Type: Bug
>    Affects Versions: 3.6
>            Reporter: Sergey Nazarov
>            Assignee: Jesse Glick
>         Attachments: snapshot-version.patch
>
>
> As of now, the plugin uses "yyyyMMdd" as a date formatting pattern for 
> snapshot versions. This results in two different snapshots built on the same 
> day having the same implementation version.
> The proposed fix (see attach) adds time to date formatting pattern.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


Reply via email to