[
https://jira.codehaus.org/browse/MJAXB-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=284418#comment-284418
]
Anders Hammar commented on MJAXB-55:
------------------------------------
I unassigned as I'm jammed with other stuff and will not have time to review
this in detail right now.
However, I think you should remove the branding stuff ("JGuru Europe AB") in
the author tags. In fact, drop the author line all together.
Also, the pom.xml is included in your patch without any functional changes
(just space changes). It should not be included.
Not sure about the skin change though. We should probably discuss that at
mojo-dev first. Possibly, we should also handle that in a separate ticket.
Robert: Do you have any thoughts on this? If we can handle it correctly I think
it would be a nice feature to include. Obviously, there is at least one person
that needs it. :-)
> Provide means to set the file name of generated XML schema
> ----------------------------------------------------------
>
> Key: MJAXB-55
> URL: https://jira.codehaus.org/browse/MJAXB-55
> Project: Maven 2.x JAXB 2.1 Plugin
> Issue Type: New Feature
> Affects Versions: 1.3.1
> Environment: All
> Reporter: Lennart Jörelid
> Attachments: fileRenamePatch_v8.txt
>
>
> AbstractSchemagenMojo sneakily hard-codes the resulting filename for the
> generated schema file.
> This should really be configurable; provided a parameter to set the resulting
> file name, as well as an integration test.
> For reasons of somewhat misguided backwards compatibility, I set the default
> value of the parameter to its currently hardcoded value, "schema1.xsd".
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
