[
https://jira.codehaus.org/browse/MNBMODULE-155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=289190#comment-289190
]
Jesse Glick commented on MNBMODULE-155:
---------------------------------------
Sorry for the delay - I am a bit overextended! Committed your second patch as
revision 15764.
Regarding {{tools.jar}} dep - if it is unavoidable, I am at least moving it
into a conditional profile (revision 15765). Otherwise the POM will be
unloadable on operating systems which do not have this JAR in the same
location, which is a critical problem since it makes projects using the plugin
also unloadable.
Now for more issues. First and foremost, the mojo does not work, at least when
I make a fresh NB platform app and add {{<goal>build-installers</goal>}} to its
{{deployment}} profile:
{code}
Failed to execute goal
org.codehaus.mojo:nbm-maven-plugin:3.7-SNAPSHOT:build-installers (extra)
on project MNBMODULE-155-app: Installers creation failed:
.../application/target/installer/nbi/stub/template.xml:41:
The following error occurred while executing this line:
.../application/target/installerbuild/build.xml:165:
java.lang.NullPointerException
{code}
Then I am wondering why {{installerOsWindows}} and the others are all false by
default. I think by default you should be building installers for all available
platforms, with an option to suppress some of them. It makes little sense for
the default behavior to be to build nothing.
You also neglected to call {{MavenProjectHelper.attachArtifact}}, so no
secondary artifact will be produced by all this work - i.e. nothing will be
installed to the local repo, deployed, published as a Hudson artifact, etc.
Please submit the {{common.xml}} patch upstream.
{{installerVerbose}} should probably be implied by the Maven verbosity ({{-e}},
{{-X}}, {{-q}}).
{{project.name}} seems a strange default for {{installDirName}}. {{<name>}}
(right?) would typically be something with whitespace and a pretty label,
whereas an install dir should be something using a conservative character set.
{{netbeans.branding.token}} seems more natural.
Finally, the mojo is lacking decent documentation. The class itself has not
even a summary sentence in its Javadoc. The {{templateFile}} and
{{userSettings}} parameters are critical, but I would never guess what you
should pass for them.
> Build installers goal
> ---------------------
>
> Key: MNBMODULE-155
> URL: https://jira.codehaus.org/browse/MNBMODULE-155
> Project: Maven NetBeans Module Plugin
> Issue Type: New Feature
> Affects Versions: 3.6
> Reporter: Frantisek Mantlik
> Assignee: Jesse Glick
> Attachments: build-installers-2.patch, build-installers.patch,
> nbm-installers-plugin.zip
>
>
> The proposal is to add a new goal which will provide similar functionality to
> "Build installers" action in IDE for mavenized RCP projects as a maven goal.
> I have developed a standalone plugin based on Ant-maven-plugin functionality
> which wrapped installer provided with Netbeans 6.9.1 and with minimum
> tweaking (mainly allowing some basic branding of generated installer) run an
> Ant task compiling and generating installers in the project application
> artifact. It is working for me on several mavenized RCP projects without any
> changes needed up to 7.1 RC1.
> I was trying to offer my plugin to Codehaus, but there was no interest -
> maybe because my advertisement was not good. I guess, that it should not be
> difficult to extract the goal from my plugin and integrate it to the
> nbm-maven-plugin as a new goal.
> Maybe, there would exist even easier way how to implement the same
> functionality to the nbm-maven-plugin?
> If there is interest in such a new feature, I could promise to do my best
> helping with development of the new goal. I am about to put one of my RCP
> projects to open-source domain and such a publicly available function would
> be helpful to it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
