Curtis Rueden created MLICENSE-34:
-------------------------------------

             Summary: Multi-line copyright holders cannot be updated
                 Key: MLICENSE-34
                 URL: https://jira.codehaus.org/browse/MLICENSE-34
             Project: Mojo's License Maven Plugin
          Issue Type: Bug
    Affects Versions: 1.0
         Environment: My configuration:
Mac OS X 10.6.8
java version "1.6.0_29"
Java(TM) SE Runtime Environment (build 1.6.0_29-b11-402-10M3527)
Java HotSpot(TM) 64-Bit Server VM (build 20.4-b02-402, mixed mode)

But bug likely affects all environments.
            Reporter: Curtis Rueden
            Assignee: Tony Chemit


I encountered a problem with license:update-file-header when the copyright 
holder string spans multiple lines. E.g.:
    https://github.com/imagej/imagej/blob/master/pom.xml#L31

I have included the line breaks for organizationName to keep the license block 
under 80 characters per line.

This works fine for adding the initial license blocks, but causes an exception 
to be thrown when processing files that already have a proper header:
    https://gist.github.com/2220296

The issue comes down to the copyright regex using dot (.) to match any 
character. But dot does not match newlines by default. The fix is easy: pass 
the Pattern.DOTALL flag when compiling the pattern.

I fixed the problem on a branch "fix-multi-line-copyright" on my Git fork of 
the code:
    
https://github.com/ctrueden/license-maven-plugin/tree/fix-multi-line-copyright

The relevant commit is:
    
https://github.com/ctrueden/license-maven-plugin/commit/01a76e7b15b750ec0c396e391a544dc803f86003


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


Reply via email to