[mojo-dev] [jira] (MJSPC-54) Support sourceVersion 1.6 or 1.7

Mon, 21 May 2012 04:45:27 -0700

Issue Type: Improvement Improvement
Assignee: Unassigned
Created: 21/May/12 6:43 AM
Description:

The latest release in the Maven repository (jspc-maven-plugin:2.0-alpha-3) does only support Java 1.5 (as newest version).

It uses the jspc-compiler-tomcat6:2.0-alpha-3 as dependency:
http://repo2.maven.org/maven2/org/codehaus/mojo/jspc/jspc-compiler-tomcat6/2.0-alpha-3/jspc-compiler-tomcat6-2.0-alpha-3.pom

Which uses <tomcatVersion>6.0.18</tomcatVersion>.
http://archive.apache.org/dist/tomcat/tomcat-6/v6.0.18/src/apache-tomcat-6.0.18-src.zip

Where in the class JDTCompiler there is a check for the version in the method generateClass

// Source JVM
        if(ctxt.getOptions().getCompilerSourceVM() != null) {
            String opt = ctxt.getOptions().getCompilerSourceVM();
            if(opt.equals("1.1")) {
                settings.put(CompilerOptions.OPTION_Source,
                             CompilerOptions.VERSION_1_1);
            } else if(opt.equals("1.2")) {
                settings.put(CompilerOptions.OPTION_Source,
                             CompilerOptions.VERSION_1_2);
            } else if(opt.equals("1.3")) { 
                settings.put(CompilerOptions.OPTION_Source,
                             CompilerOptions.VERSION_1_3);
            } else if(opt.equals("1.4")) {
                settings.put(CompilerOptions.OPTION_Source,
                             CompilerOptions.VERSION_1_4);
            } else if(opt.equals("1.5")) {
                settings.put(CompilerOptions.OPTION_Source,
                             CompilerOptions.VERSION_1_5);
            } else {
                log.warn("Unknown source VM " + opt + " ignored.");
                settings.put(CompilerOptions.OPTION_Source,
                        CompilerOptions.VERSION_1_5);
            }
        } else {
            // Default to 1.5
            settings.put(CompilerOptions.OPTION_Source,
                    CompilerOptions.VERSION_1_5);
        }


With newer Jasper versions, also 1.6 or 1.7 is supported.



It would be nice too have a new release, using the latest tomcatVersion, currently: 6.0.35
Environment: 2.0-alpha-3
Project: Maven 2.x JSPC Plugin
Priority: Critical Critical
Reporter: Roman Cerny
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email

Reply via email to