Issue Type: Bug Bug
Affects Versions: 1.0.1
Assignee: Unassigned
Attachments: AbstractImportMojo.java
Created: 10/Aug/12 5:11 AM
Description:

I have a parent POM file which contains several modules. Each module extends the _javascript_-maven-tools maven extension (using packaging type "js"). One module is called "Project A", while the other is called "Project B".

+ Parent
++ Project A
++ Project B

Project B is dependent on Project A.

When running a Maven install command on Project A, it completes succesfully. When running an install command on Project B the js-import-maven-plugin detects Project A in the repository and imports it.

However if you add "Project A" and "Project B" as modules to the parent like so:

<modules>
<module>Project A</module>
<module>Porject B</module>
</modules>

and Run the Maven Install command on the Parent, it will build Project A successfully but will fail on importing Project B with an import error (unable to find repository for 1-min.js found within Project A).

I believe the JS-Import-Maven_plugin is detecting the webminified versions of "Project A" and does not it should be discarded and is instead throwing an error.

I have written a patch (see attached) that looks for _javascript_-maven-tools minified files, it will report to the debugger which minified files are being ignored. If the unkown file doesn't support that format (e.g. 1-min.js, 2-min.js) it will stop and throw an error.

Second part of the fix is because the file is minified it doesn't exist in the export dependency list, the last part of the function assume all artifact files do. So I added a null check to stop a null pointer exception.

Will create a unit test for this when I have time this evening.

Project: Mojo _javascript_ Import Maven Plugin
Priority: Major Major
Reporter: Stephen Crocker
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email

Reply via email to