Anders Hammar commented on Improvement MRPM-121

Comment from Graham Leggett in mail thread on dev list:

With the above dependency reverted we get a package containing this:

[minfrin@257233-app1 rpm-maven-plugin-trunk]$ rpm -q -l --package target/it/rpm-1/target/rpm/rpm-1/RPMS/noarch/rpm-1-1.0-1.noarch.rpm
/tmp/myapp/somefile
/tmp/myapp/somefile2
/usr/myusr/app
/usr/myusr/app/bin/filter-version.txt
/usr/myusr/app/bin/filter.txt
/usr/myusr/app/bin/name-Linux.sh
/usr/myusr/app/bin/name.sh
/usr/myusr/app/bin/oldname.sh
/usr/myusr/app/bin/start.sh
/usr/myusr/app/conf
/usr/myusr/app/conf/log4j.xml
/usr/myusr/app/conf/log4j.xml.deliver
/usr/myusr/app/lib
/usr/myusr/app/lib/grizzly-comet-counter.war
/usr/myusr/app2

With the upgraded dependency we get this:

[minfrin@257233-app1 rpm-maven-plugin-trunk]$ rpm -q -l --package target/it/rpm-1/target/rpm/rpm-1/RPMS/noarch/rpm-1-1.0-1.noarch.rpm
/tmp/myapp/somefile
/tmp/myapp/somefile2
/usr/myusr/app
/usr/myusr/app/bin/name-Linux.sh
/usr/myusr/app/bin/name.sh
/usr/myusr/app/bin/oldname.sh
/usr/myusr/app/conf
/usr/myusr/app/conf/log4j.xml
/usr/myusr/app/conf/log4j.xml.deliver
/usr/myusr/app/lib
/usr/myusr/app/lib/grizzly-comet-counter.war
/usr/myusr/app2

Seems everything in the bin directory is missing from the build:

src/it/rpm-1/src/main/bin/

/usr/myusr/app/bin/filter-version.txt
/usr/myusr/app/bin/filter.txt
/usr/myusr/app/bin/start.sh

According to the pom file in src/it/rpm-1/pom.xml, the start.sh file should in theory not be imported at all.

Then we have this bit of config on the pom:

<source>
<location>src/main/bin</location>
<excludes>
<exclude>*install.sh</exclude>
<exclude>filter.txt</exclude>
</excludes>
</source>
<source>
<location>src/main/bin</location>
<includes>
<include>filter*</include>
</includes>
<filter>true</filter>
</source>

Not sure what the above is trying to achieve, it first tries to exclude filter.txt, then it tries to include filter*. I think the exclude now wins over the include.

In the case of the filter-version.txt file, not seeing why that is disappearing, in theory the <include>filter*</include> should catch it, not sure.

I think the change in filesize is correct, the file size should probably be 12, not 15.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email

Reply via email to