ideally you would create 2 issues and 2 patches as the issues are not directly related.

1. I don't follow this condition (see below) what is the purpose of it?

if (brandingDir.isDirectory()) {
    Parallel parallelTask = (Parallel) antProject.createTask("parallel");

2. under what circumstances is the jnlp servlet jar missing from the jdk?
3. Usage of URL.openConnection is probably suboptimal here to download the file and apache maven's Wagon library should be used which handles proxies gracefully (with relation to the build itself)

4. possible security issue: why download from http://www.java2s.com/ rather than some official oracle site? It's not on an official place or in maven repo? then failing is probably better.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email

Reply via email to